Re: Issue 2269 in reviewboard: reviewers can review uploaded file just like diff file

2011-09-06 Thread reviewboard


Comment #2 on issue 2269 by wangxiao...@gmail.com: reviewers can review  
uploaded file just like diff file

http://code.google.com/p/reviewboard/issues/detail?id=2269

all files(.txt .java .c .h .php .js .css .xml .py .sh .pl etc) expect  
Binary files and pictures


--
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.



Re: Issue 2269 in reviewboard: reviewers can review uploaded file just like diff file

2011-09-05 Thread reviewboard

Updates:
Status: NeedInfo

Comment #1 on issue 2269 by trowb...@gmail.com: reviewers can review  
uploaded file just like diff file

http://code.google.com/p/reviewboard/issues/detail?id=2269

Can you clarify which file types you'd like to be able to review?

--
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.



Issue 2269 in reviewboard: reviewers can review uploaded file just like diff file

2011-09-01 Thread reviewboard

Status: New
Owner: 
Labels: Type-Enhancement Priority-Medium

New issue 2269 by wangxiao...@gmail.com: reviewers can review uploaded file  
just like diff file

http://code.google.com/p/reviewboard/issues/detail?id=2269

*NOTE: If you have a patch, please submit it to
http://reviews.reviewboard.org/


What version are you running?
1.6 RC2

What's the URL of the page this enhancement relates to, if any?


Describe the enhancement and the motivation for it.
user can add a file to review. In 1.6 RC2, usre can only add a file, but  
reviewers cant't reiview this file like view diff.


my requirement is submiter can mark the file as need to review or not,  
while upload the file. if mark as need to review, reviewer can see it in  
view diff, the file can display as newcontent, and reviewer can add comment.


What operating system are you using? What browser?
Red Hat Enterprise Linux Server release 5.4 (Tikanga) 64
IE8 、 firefox 、 chrom

Please provide any additional information below.


--
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.