Re: Issue 2340 in reviewboard: Reviewboard posts wrong Diff URL in notification emails
Comment #5 on issue 2340 by goliat...@gmail.com: Reviewboard posts wrong Diff URL in notification emails http://code.google.com/p/reviewboard/issues/detail?id=2340 great. thanks a lot! -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 2340 in reviewboard: Reviewboard posts wrong Diff URL in notification emails
Updates: Status: Fixed Comment #4 on issue 2340 by trowb...@gmail.com: Reviewboard posts wrong Diff URL in notification emails http://code.google.com/p/reviewboard/issues/detail?id=2340 Fixed in release-1.6.x (0d1c6e8) -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 2340 in reviewboard: Reviewboard posts wrong Diff URL in notification emails
Updates: Status: New Comment #3 on issue 2340 by trowb...@gmail.com: Reviewboard posts wrong Diff URL in notification emails http://code.google.com/p/reviewboard/issues/detail?id=2340 This is actually a real bug, but it only shows up in the plain text part of the email. There's a fix for this in issue 2366 which I'll be committing today. -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 2340 in reviewboard: Reviewboard posts wrong Diff URL in notification emails
Comment #2 on issue 2340 by goliat...@gmail.com: Reviewboard posts wrong Diff URL in notification emails http://code.google.com/p/reviewboard/issues/detail?id=2340 not that I know of. maybe years old, but those wouldn't survive an update right? how would I check? which path would I need to compare to an unmodified release? -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 2340 in reviewboard: Reviewboard posts wrong Diff URL in notification emails
Updates: Status: NeedInfo Comment #1 on issue 2340 by chip...@gmail.com: Reviewboard posts wrong Diff URL in notification emails http://code.google.com/p/reviewboard/issues/detail?id=2340 Hmm, we haven't noticed this in our deployments. We use Django to tell us the location of the diff, which should always be a valid path. Do you have any customizations of templates anywhere? -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Issue 2340 in reviewboard: Reviewboard posts wrong Diff URL in notification emails
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 2340 by goliat...@gmail.com: Reviewboard posts wrong Diff URL in notification emails http://code.google.com/p/reviewboard/issues/detail?id=2340 What version are you running? 1.6.1 What's the URL of the page containing the problem? http://mail.kde.org/pipermail/kde-utils-devel/2011-October/000668.html What steps will reproduce the problem? 1. Make sure, email notification for review requests is enabled 2. Create Review Request What is the expected output? What do you see instead? Reviewboard sends an Email to the configured address containing an url to a diff view. This URL reads: http://git.reviewboard.kde.org/r/102785/diff/diff which gives a 404 error. The URL should read http://git.reviewboard.kde.org/r/102785/diff instead. -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
