Re: Issue 2515 in reviewboard: Exception thrown when trying to post a review to an http basic auth backed instance of review board
Comment #4 on issue 2515 by huhu...@gmail.com: Exception thrown when trying to post a review to an http basic auth backed instance of review board http://code.google.com/p/reviewboard/issues/detail?id=2515 I use this cmd to get it passed: post-review --http-username name --http-password pwd --username name --password pwd I guess it's due to my cookie in ~/.post-review-cookies.txt is removed. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Issue 2515 in reviewboard: Exception thrown when trying to post a review to an http basic auth backed instance of review board
Updates: Status: Fixed Comment #3 on issue 2515 by trowb...@gmail.com: Exception thrown when trying to post a review to an http basic auth backed instance of review board http://code.google.com/p/reviewboard/issues/detail?id=2515 This has since been fixed. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/groups/opt_out.
Re: Issue 2515 in reviewboard: Exception thrown when trying to post a review to an http basic auth backed instance of review board
Comment #2 on issue 2515 by njhar...@gmail.com: Exception thrown when trying to post a review to an http basic auth backed instance of review board http://code.google.com/p/reviewboard/issues/detail?id=2515 The code is not checking for None return value from urllib2. One possible fix is following patch. 132c132 < if response and response.code != 401: --- if response.code != 401: -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/groups/opt_out.
Re: Issue 2515 in reviewboard: Exception thrown when trying to post a review to an http basic auth backed instance of review board
Updates: Labels: Component-RBTools Comment #1 on issue 2515 by trowb...@gmail.com: Exception thrown when trying to post a review to an http basic auth backed instance of review board http://code.google.com/p/reviewboard/issues/detail?id=2515 (No comment was entered for this change.) -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Issue 2515 in reviewboard: Exception thrown when trying to post a review to an http basic auth backed instance of review board
Status: New
Owner:
Labels: Type-Defect Priority-Medium
New issue 2515 by a...@indydevs.org: Exception thrown when trying to post a
review to an http basic auth backed instance of review board
http://code.google.com/p/reviewboard/issues/detail?id=2515
Server setup:
- python 2.7.1
- centos 5.5
Client setup
- python 2.7.1
- rbtools 0.4.1
Note
- problem only occurs when a username is not specified on the command line
or in the rc file.
post-review --parent=${review_hash}
Traceback (most recent call last):
File "/usr/local/bin/post-review", line 9, in
load_entry_point('RBTools==0.4.1.dev', 'console_scripts', 'post-review')()
File "/Library/Python/2.7/site-packages/RBTools-0.4.1.dev-py2.7.egg/rbtools/postreview.py",
line 1222, in main
if not server.check_api_version():
File "/Library/Python/2.7/site-packages/RBTools-0.4.1.dev-py2.7.egg/rbtools/postreview.py",
line 226, in check_api_version
root_resource = self.api_get('api/')
File "/Library/Python/2.7/site-packages/RBTools-0.4.1.dev-py2.7.egg/rbtools/postreview.py",
line 669, in api_get
return self.process_json(self.http_get(path))
File "/Library/Python/2.7/site-packages/RBTools-0.4.1.dev-py2.7.egg/rbtools/postreview.py",
line 639, in http_get
rsp = urllib2.urlopen(url).read()
File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/urllib2.py",
line 126, in urlopen
return _opener.open(url, data, timeout)
File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/urllib2.py",
line 400, in open
response = meth(req, response)
File "/Library/Python/2.7/site-packages/RBTools-0.4.1.dev-py2.7.egg/rbtools/postreview.py",
line 97, in http_response
response.info())
File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/urllib2.py",
line 432, in error
result = self._call_chain(*args)
File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/urllib2.py",
line 372, in _call_chain
result = func(*args)
File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/urllib2.py",
line 884, in http_error_401
url, req, headers)
File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/urllib2.py",
line 859, in http_error_auth_reqed
response = self.retry_http_basic_auth(host, req, realm)
File "/Library/Python/2.7/site-packages/RBTools-0.4.1.dev-py2.7.egg/rbtools/postreview.py",
line 129, in retry_http_basic_auth
if response.code != 401:
AttributeError: 'NoneType' object has no attribute 'code'
Git bisect led me to
https://github.com/reviewboard/rbtools/commit/c27a1e2827f8b2fc7e2a0d4bf6b0e450ccb64c6a
being the culprit where the realm is being compared to a hard coded
string 'Web API'.
--
You received this message because you are subscribed to the Google Groups
"reviewboard-issues" group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at
http://groups.google.com/group/reviewboard-issues?hl=en.
