Re: Issue 2553 in reviewboard: /api/review-requests/#/diffs/#/files/#/ will 404 with empty response when ids are invalid

2012-10-24 Thread reviewboard 

Updates:
Status: UserError
Labels: -Priority-Medium -EasyFix

Comment #5 on issue 2553 by ste...@smacleod.ca:  
/api/review-requests/#/diffs/#/files/#/ will 404 with empty response when  
ids are invalid

http://code.google.com/p/reviewboard/issues/detail?id=2553

As mentioned previously, this is not a bug, but merely the result of  
browsers hiding the payload.


--
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.

Re: Issue 2553 in reviewboard: /api/review-requests/#/diffs/#/files/#/ will 404 with empty response when ids are invalid

2012-09-28 Thread reviewboard 


Comment #4 on issue 2553 by miche.ch...@gmail.com:  
/api/review-requests/#/diffs/#/files/#/ will 404 with empty response when  
ids are invalid

http://code.google.com/p/reviewboard/issues/detail?id=2553

The page does actually return with an error payload, but it doesn't seem to  
show up with certain plugins like Firebug or Chrome REST Console.


--
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.

Re: Issue 2553 in reviewboard: /api/review-requests/#/diffs/#/files/#/ will 404 with empty response when ids are invalid

2012-09-28 Thread reviewboard 


Comment #3 on issue 2553 by miche.ch...@gmail.com:  
/api/review-requests/#/diffs/#/files/#/ will 404 with empty response when  
ids are invalid

http://code.google.com/p/reviewboard/issues/detail?id=2553

Will look into this. - Michelle C.

--
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.

Re: Issue 2553 in reviewboard: /api/review-requests/#/diffs/#/files/#/ will 404 with empty response when ids are invalid

2012-09-28 Thread reviewboard 


Comment #2 on issue 2553 by sinn.fon...@gmail.com:  
/api/review-requests/#/diffs/#/files/#/ will 404 with empty response when  
ids are invalid

http://code.google.com/p/reviewboard/issues/detail?id=2553

Will look into this.

--
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.

Re: Issue 2553 in reviewboard: /api/review-requests/#/diffs/#/files/#/ will 404 with empty response when ids are invalid

2012-03-31 Thread reviewboard 

Updates:
Labels: EasyFix

Comment #1 on issue 2553 by mike.d.c...@gmail.com:  
/api/review-requests/#/diffs/#/files/#/ will 404 with empty response when  
ids are invalid

http://code.google.com/p/reviewboard/issues/detail?id=2553

(No comment was entered for this change.)

--
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.

Issue 2553 in reviewboard: /api/review-requests/#/diffs/#/files/#/ will 404 with empty response when ids are invalid

2012-03-26 Thread reviewboard 

Status: Accepted
Owner: 
Labels: Type-Defect Priority-Medium

New issue 2553 by ste...@smacleod.ca:  
/api/review-requests/#/diffs/#/files/#/ will 404 with empty response when  
ids are invalid

http://code.google.com/p/reviewboard/issues/detail?id=2553

What version are you running?
1.6.4+ (Probably earlier as well)

What's the URL of the page containing the problem?
/api/review-requests/{review-request-id}/diffs/{diff-id}/files/{file-id}/  
where at least one of the id numbers is invalid.


What steps will reproduce the problem?
1.Visit the URL

What is the expected output? What do you see instead?
This should return the 404 page with the error payload. Instead, a 404 with  
an empty response body is returned.


What operating system are you using? What browser?
Ubuntu 11.10, Chrome 18

Please provide any additional information below.

--
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.