Re: Issue 2583 in reviewboard: Unable to process patch for new files with empty revision

2012-11-25 Thread reviewboard 

Updates:
Status: ThirdParty

Comment #1 on issue 2583 by trowb...@gmail.com: Unable to process patch for  
new files with empty revision

http://code.google.com/p/reviewboard/issues/detail?id=2583

Unfortunately, IntelliJ uses this format both as (revision 0) and (working  
copy), which are different things. We already have code in there that tries  
to convert this to be (working copy). See bug 1937 for details. I think  
fundamentally this is a bug in IntelliJ IDEA.


--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.

Issue 2583 in reviewboard: Unable to process patch for new files with empty revision

2012-04-27 Thread reviewboard 

Status: New
Owner: 
Labels: Type-Defect Priority-Medium

New issue 2583 by stanis...@doktorovich.com: Unable to process patch for  
new files with empty revision

http://code.google.com/p/reviewboard/issues/detail?id=2583

* NOTE: Do not post confidential information in this bug report. *
*   If you need immediate support, please contact*
*   reviewbo...@googlegroups.com *

What version are you running?
1.6.6

What's the URL of the page containing the problem?
New Review Request http://domain.com/r/new

What steps will reproduce the problem?
IntelliJ IDEA generates SVN patch with empty revision number for new files.
Example:

Index: sql/mysql/F_SUBSCRIPTION_ID.sql
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
+UTF-8
===
--- sql/mysql/F_SUBSCRIPTION_ID.sql (revision )
+++ sql/mysql/F_SUBSCRIPTION_ID.sql (revision )
@@ -0,0 +1,3 @@
+use home;
+
+ALTER TABLE T_SUBSCRIPTION ADD F_SUBSCRIPTION_ID VARCHAR(40) NULL;
\ No newline at end of file

And when I manually update revision to 0 RB is able to process it
Example:
--- sql/mysql/F_SUBSCRIPTION_ID.sql (revision 0)
+++ sql/mysql/F_SUBSCRIPTION_ID.sql (revision )


--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.