Re: Issue 2703 in reviewboard: --guess-summary doesn't work when summary has newline characters in it

2012-10-07 Thread reviewboard

Updates:
Status: Fixed

Comment #3 on issue 2703 by trowb...@gmail.com: --guess-summary doesn't  
work when summary has newline characters in it

http://code.google.com/p/reviewboard/issues/detail?id=2703

Pushed to master (423b9bb). Thanks!

--
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.



Re: Issue 2703 in reviewboard: --guess-summary doesn't work when summary has newline characters in it

2012-09-27 Thread reviewboard

Updates:
Status: Confirmed
Labels: Component-RBTools

Comment #2 on issue 2703 by chip...@gmail.com: --guess-summary doesn't work  
when summary has newline characters in it

http://code.google.com/p/reviewboard/issues/detail?id=2703

Can you post your patch on http://reviews.reviewboard.org/ ?

--
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.



Re: Issue 2703 in reviewboard: --guess-summary doesn't work when summary has newline characters in it

2012-09-27 Thread reviewboard


Comment #1 on issue 2703 by alexande...@gmail.com: --guess-summary doesn't  
work when summary has newline characters in it

http://code.google.com/p/reviewboard/issues/detail?id=2703

I propose the attached fix.

Attachments:
change.diff  1.8 KB

--
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.



Issue 2703 in reviewboard: --guess-summary doesn't work when summary has newline characters in it

2012-08-13 Thread reviewboard

Status: New
Owner: 
Labels: Type-Defect Priority-Medium

New issue 2703 by alexande...@gmail.com: --guess-summary doesn't work when  
summary has newline characters in it

http://code.google.com/p/reviewboard/issues/detail?id=2703

* NOTE: Do not post confidential information in this bug report. *
*   If you need immediate support, please contact*
*   reviewbo...@googlegroups.com *

What version are you running?
RBTools 0.4.1
Review Board 1.6.9
Mercurial Distributed SCM (version 2.2.1)

What's the URL of the page containing the problem?


What steps will reproduce the problem?
1. Commit Mercurial change with newline character in commit message.
2. invoke post-review -p --revision-range=tip --guess-summary

What is the expected output?

Review request #11440 posted.

What do you see instead?

Error creating review request: One or more fields had errors (HTTP 400, API  
Error 105)




What operating system are you using? What browser?

Windows 7 x64


Please provide any additional information below.

When I run it with -d option I get the following output:


RBTools 0.4.1
Home = C:\Users\username\AppData\Roaming
HTTP GETting api/
HTTP GETting http://server.address.company.com/api/info/
Using the new web API
Attempting to create review request on 337 for None
HTTP POSTing to http://server.address.company.com/api/review-requests/:  
{'repository': 337}

Review request created
Attempting to set field 'target_people' to 'name' for review  
request '11442'
HTTP PUTting to  
http://server.address.company.com/api/review-requests/11442/draft/:  
{'target_people': 'name'}

Attempting to set field 'summary' to 'Product: Added new feature.

' for review request '11442'
HTTP PUTting to  
http://server.address.company.com/api/review-requests/11442/draft/:  
{'summary': 'Product: Added new feature.\n'}

Got API Error 105 (HTTP code 400): One or more fields had errors
Error data: {u'fields': {u'summary': [u'Summary cannot contain  
newlines']}, u'stat': u'fail', u'draft': {u'last_updated': u'2012-08-13  
05:15:09', u'description': u'', u'links': {u'self': {u'href':
 u'http://server.address.company.com/api/review-requests/11442/draft/',  
u'method': u'GET'}, u'update': {u'href':  
u'http://server.address.company.com/api/review-requests/11442/draft/',  
u'method': u'PUT'}, u'draft_
screenshots': {u'href':  
u'http://server.address.company.com/api/review-requests/11442/draft/screenshots/',  
u'method': u'GET'}, u'draft_file_attachments': {u'href':  
u'http://server.address.company.com/api/review-r
equests/11442/draft/file-attachments/', u'method': u'GET'},  
u'review_request': {u'href':  
u'http://server.address.company.com/api/review-requests/11442/', u'method':  
u'GET', u'title': u'(no summary)'}, u'del
ete': {u'href':  
u'http://server.address.company.com/api/review-requests/11442/draft/',  
u'method': u'DELETE'}}, u'changedescription': u'', u'target_groups': [],  
u'bugs_closed': [], u'target_people': [{u'href
': u'http://server.address.company.com/api/users/name/', u'method': u'GET',  
u'title': u'name'}], u'testing_done': u'', u'branch': u'', u'id': 15005,  
u'summary': u'', u'public': False}, u'err': {u'msg': u'

One or more fields had errors', u'code': 105}}
Error creating review request: One or more fields had errors (HTTP 400, API  
Error 105)


--
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.