Re: Issue 2707 in reviewboard: Unable to publish a review with comments on a screenshot
Updates: Status: Fixed Comment #4 on issue 2707 by trowb...@gmail.com: Unable to publish a review with comments on a screenshot http://code.google.com/p/reviewboard/issues/detail?id=2707 Pushed to release-1.6.x (900d064). Thanks! -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 2707 in reviewboard: Unable to publish a review with comments on a screenshot
Comment #2 on issue 2707 by timw.at@gmail.com: Unable to publish a
review with comments on a screenshot
http://code.google.com/p/reviewboard/issues/detail?id=2707
The following workaround fixed it for me (which was enough to restore
functionality for my users while a real fix is implemented):
diff --git a/reviewboard/htdocs/media/rb/js/reviews.js
b/reviewboard/htdocs/media/rb/js/reviews.js
index 9888b4a..53e675b 100644
--- a/reviewboard/htdocs/media/rb/js/reviews.js
+++ b/reviewboard/htdocs/media/rb/js/reviews.js
@@ -1435,7 +1435,8 @@ $.reviewForm = function(review) {
$(.comment-editable, dlg).each(function() {
var editable = $(this);
var comment = editable.data('comment');
-var issueOpened = editable.next()[0].checked;
+var issueOpened_ = editable.next()[0];
+var issueOpened = issueOpened_ ? issueOpened_.checked : false;
if (editable.inlineEditor(dirty) ||
issueOpened != comment.issue_opened) {
--
You received this message because you are subscribed to the Google Groups
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at
http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 2707 in reviewboard: Unable to publish a review with comments on a screenshot
Updates: Status: Confirmed Owner: chip...@gmail.com Labels: -Priority-Medium Priority-Critical Milestone-Release1.6.x Component-Reviews Comment #3 on issue 2707 by chip...@gmail.com: Unable to publish a review with comments on a screenshot http://code.google.com/p/reviewboard/issues/detail?id=2707 (No comment was entered for this change.) -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 2707 in reviewboard: Unable to publish a review with comments on a screenshot
Comment #1 on issue 2707 by matt.mul...@gmail.com: Unable to publish a review with comments on a screenshot http://code.google.com/p/reviewboard/issues/detail?id=2707 I just tested with 1.7 beta 1 and this issue appears to be fixed there. The Open an Issue checkbox shows up on comments on images there. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Issue 2707 in reviewboard: Unable to publish a review with comments on a screenshot
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 2707 by matt.mul...@gmail.com: Unable to publish a review with comments on a screenshot http://code.google.com/p/reviewboard/issues/detail?id=2707 * NOTE: Do not post confidential information in this bug report. * * If you need immediate support, please contact* * reviewbo...@googlegroups.com * What version are you running? 1.6.11 What's the URL of the page containing the problem? http://reviewboard.example.com/r/26265/diff/#index_header What steps will reproduce the problem? 1. Publish a review request with a screenshot 2. Add a comment on the screenshot 3. Click Edit Review in the You have a pending review header 4. Click Publish Review What is the expected output? What do you see instead? I expect to be returned to the main page for the review request showing my new review. Instead I'm left on the View Diff page with the You have a pending review header showing. In the Javascript console I get the error Uncaught TypeError: Cannot read property 'checked' of undefined from reviews.js on line 1438. What operating system are you using? What browser? Windows 7, Chrome Please provide any additional information below. It appears that the Javascript code is looking for the Open an issue checkbox, but the comments on screenshots do not seem to have the Open an issue checkbox like the comments on code do. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
