Re: Issue 2758 in reviewboard: Comparing UTF8 text files doesn't highlight correctly downloaded diff is not UTF8

2012-12-23 Thread reviewboard

Updates:
Labels: Component-DiffViewer

Comment #1 on issue 2758 by trowb...@gmail.com: Comparing UTF8 text files  
doesn't highlight correctly  downloaded diff is not UTF8

http://code.google.com/p/reviewboard/issues/detail?id=2758

(No comment was entered for this change.)

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.



Issue 2758 in reviewboard: Comparing UTF8 text files doesn't highlight correctly downloaded diff is not UTF8

2012-10-02 Thread reviewboard

Status: New
Owner: 
Labels: Type-Defect Priority-Medium

New issue 2758 by lruc...@mac.com: Comparing UTF8 text files doesn't  
highlight correctly  downloaded diff is not UTF8

http://code.google.com/p/reviewboard/issues/detail?id=2758

* NOTE: Do not post confidential information in this bug report. *
*   If you need immediate support, please contact*
*   reviewbo...@googlegroups.com *

What version are you running?

1.6.9
What's the URL of the page containing the problem?
https://reviewboard.eng.vmware.com/r/385645/

What steps will reproduce the problem?
1. Compare UTF8 text files with multibyte characters.

What is the expected output? What do you see instead?
The highlighting doesn't always select the correct character and the  
downloaded diff is not UTF8 - see the .css file for the downloaded diff and  
p5diff.txt for the result of p5 diff -du -c


Also included a screenshot showing incorrect  correct highlighting. If  
there are any multibyte characters before the diff, the diff is offset.


What operating system are you using? What browser?

Mac OSX 10.8.2
Safari 6.0.1

Please provide any additional information below.
I used post-review

Attachments:
bug920012.patch.css  17.9 KB
p5diff.txt  17.3 KB
Screen Shot 10-2-12 at 2.48.46 PM.png  228 KB

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.