Issue 2788 in reviewboard: after update some old reviews fail to show diff view.

2012-10-29 Thread reviewboard

Status: New
Owner: 
Labels: Type-Defect Priority-Medium

New issue 2788 by dotheb...@gmail.com: after update some old reviews fail  
to show diff view.

http://code.google.com/p/reviewboard/issues/detail?id=2788

* NOTE: For customer support, please post to *
*   reviewbo...@googlegroups.com *
**
*   Do not post confidential information in this bug report. *
*   If you need immediate support, please contact*
*   reviewbo...@googlegroups.com *

What version are you running?
1.6.13

What's the URL of the page containing the problem?
/r/383/diff/#index_header

What steps will reproduce the problem?
always produceable.


What is the expected output? What do you see instead?
   
File /usr/lib/python2.4/site-packages/Djblets-0.6.23-py2.4.egg/djblets/util/decorators.py,  
line 119, in render

return self.tag_func(context, *args)
   
File /usr/lib/python2.4/site-packages/ReviewBoard-1.6.13-py2.4.egg/reviewboard/diffviewer/templatetags/difftags.py,  
line 204, in diff_chunk_header

if header['line'] = line[1]:
TemplateSyntaxError: Caught TypeError while rendering: string indices must  
be integers



What operating system are you using? What browser?
shows in all browsers.

Please provide any additional information below.





Attachments:
fullbacktrace.txt  5.3 KB

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.



Re: Issue 2788 in reviewboard: after update some old reviews fail to show diff view.

2012-10-29 Thread reviewboard

Updates:
Status: Confirmed
Owner: chip...@gmail.com
	Labels: -Priority-Medium Priority-High Milestone-Release1.6.x  
Component-DiffViewer


Comment #2 on issue 2788 by chip...@gmail.com: after update some old  
reviews fail to show diff view.

http://code.google.com/p/reviewboard/issues/detail?id=2788

Restart your memcached and the problem will go away. A cache key didn't get  
bumped when the format of the diff cache changed. We'll deploy a fix in the  
next release.


--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.



Re: Issue 2788 in reviewboard: after update some old reviews fail to show diff view.

2012-10-29 Thread reviewboard


Comment #3 on issue 2788 by dotheb...@gmail.com: after update some old  
reviews fail to show diff view.

http://code.google.com/p/reviewboard/issues/detail?id=2788

yes, this fixes the behaviour.
Maybe setup should point the user to restart memcached in such a case.

Tnx a lot.

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.



Re: Issue 2788 in reviewboard: after update some old reviews fail to show diff view.

2012-10-29 Thread reviewboard


Comment #4 on issue 2788 by chip...@gmail.com: after update some old  
reviews fail to show diff view.

http://code.google.com/p/reviewboard/issues/detail?id=2788

It's a bug. I'd rather fix it than have setup tell you to work around it :)  
(And if we knew about it before releasing, we'd have fixed it then.)


--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.