Re: Issue 2833 in reviewboard: post-review needs to override git diff.renames option

2013-04-25 Thread reviewboard


Comment #5 on issue 2833 by matthew@kitware.com: post-review needs to  
override git diff.renames option

http://code.google.com/p/reviewboard/issues/detail?id=2833

https://github.com/reviewboard/rbtools/commit/bacdab01f33c75911d03a49ff0115d9d99287a82?

--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.




Re: Issue 2833 in reviewboard: post-review needs to override git diff.renames option

2013-04-25 Thread reviewboard


Comment #4 on issue 2833 by orsent...@gmail.com: post-review needs to  
override git diff.renames option

http://code.google.com/p/reviewboard/issues/detail?id=2833

I could not find the change bacdab01f33 and clients/git.py  - What am I  
missing here?


--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.




Re: Issue 2833 in reviewboard: post-review needs to override git diff.renames option

2013-01-08 Thread reviewboard

Updates:
Status: Fixed

Comment #3 on issue 2833 by trowb...@gmail.com: post-review needs to  
override git diff.renames option

http://code.google.com/p/reviewboard/issues/detail?id=2833

(No comment was entered for this change.)

--
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.



Re: Issue 2833 in reviewboard: post-review needs to override git diff.renames option

2013-01-08 Thread reviewboard


Comment #2 on issue 2833 by matthew@kitware.com: post-review needs to  
override git diff.renames option

http://code.google.com/p/reviewboard/issues/detail?id=2833

This is fixed as of bacdab01f33; can someone with adequate permissions  
please close?


--
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.



Re: Issue 2833 in reviewboard: post-review needs to override git diff.renames option

2012-12-24 Thread reviewboard

Updates:
Labels: Component-RBTools

Comment #1 on issue 2833 by trowb...@gmail.com: post-review needs to  
override git diff.renames option

http://code.google.com/p/reviewboard/issues/detail?id=2833

(No comment was entered for this change.)

--
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.



Issue 2833 in reviewboard: post-review needs to override git diff.renames option

2012-12-19 Thread reviewboard

Status: New
Owner: 
Labels: Type-Defect Priority-Medium

New issue 2833 by matthew@kitware.com: post-review needs to override  
git diff.renames option

http://code.google.com/p/reviewboard/issues/detail?id=2833

What version are you running?
RBTools 0.4.2

What steps will reproduce the problem?
1. git config diff.rename copies
2. Try to post a request in which git diff detects copies

What is the expected output? What do you see instead?
Uploading diff fails.

Please provide any additional information below.
clients/git.py needs to add '--no-renames' to git diff arguments to avoid  
automatic copy detection specified by user config.


--
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.