Re: Issue 2966 in reviewboard: SVN Path persisted in FileDiff.source_file which makes it break when the repository path is migrated to a new path
Updates: Labels: Component-DiffParser Comment #3 on issue 2966 by trowb...@gmail.com: SVN Path persisted in FileDiff.source_file which makes it break when the repository path is migrated to a new path http://code.google.com/p/reviewboard/issues/detail?id=2966 (No comment was entered for this change.) -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/groups/opt_out.
Re: Issue 2966 in reviewboard: SVN Path persisted in FileDiff.source_file which makes it break when the repository path is migrated to a new path
Comment #2 on issue 2966 by lamott...@gmail.com: SVN Path persisted in FileDiff.source_file which makes it break when the repository path is migrated to a new path http://code.google.com/p/reviewboard/issues/detail?id=2966 AFAIK, the user is running post-review from the sandbox. Regardless, I can't imagine it would be a bad thing to strip the repo.path from the source_file and then prepend it later when get_file() is called right? -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
Re: Issue 2966 in reviewboard: SVN Path persisted in FileDiff.source_file which makes it break when the repository path is migrated to a new path
Comment #1 on issue 2966 by chip...@gmail.com: SVN Path persisted in FileDiff.source_file which makes it break when the repository path is migrated to a new path http://code.google.com/p/reviewboard/issues/detail?id=2966 I assume you're invoking post-review not from a local repository but by diffing against a remote repository? If so, there's nothing we can do about this. This is svn diff generating the path. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
Issue 2966 in reviewboard: SVN Path persisted in FileDiff.source_file which makes it break when the repository path is migrated to a new path
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 2966 by lamott...@gmail.com: SVN Path persisted in FileDiff.source_file which makes it break when the repository path is migrated to a new path http://code.google.com/p/reviewboard/issues/detail?id=2966 What version are you running? 1.7.6 What's the URL of the page containing the problem? /r//diff/ What steps will reproduce the problem? 1. Create a subversion repository (path something like http://hostname/svn/path) 2. Post Review against subversion repository 3. Change Path of subversion Repository (think deprecating old server, moving to new server situation; new path https://newhostname/svn/path) What is the expected output? What do you see instead? Old Reviews (against the old path) blow up because they attempt to access the old location (because its persisted in FileDiff.source_file column of the database table) I would expect the review would continue to work and simply use the new path associated with the repository. The correct fix would be to not persist the repository part of the path in source_file. What operating system are you using? What browser? Mac. Chrome. Please provide any additional information below. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
