Re: Issue 3005 in reviewboard: timezone string limited to 20 char whereas some timezones are greater than 20
Updates: Status: Fixed Owner: chip...@gmail.com Labels: Milestone-Release1.7.x Component-Accounts Comment #3 on issue 3005 by chip...@gmail.com: timezone string limited to 20 char whereas some timezones are greater than 20 http://code.google.com/p/reviewboard/issues/detail?id=3005 Fixed on release-1.7.x (ee9b33d) -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/groups/opt_out.
Re: Issue 3005 in reviewboard: timezone string limited to 20 char whereas some timezones are greater than 20
Comment #2 on issue 3005 by nano...@gmail.com: timezone string limited to 20 char whereas some timezones are greater than 20 http://code.google.com/p/reviewboard/issues/detail?id=3005 I propose following change http://reviews.reviewboard.org/r/4230 -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
Re: Issue 3005 in reviewboard: timezone string limited to 20 char whereas some timezones are greater than 20
Comment #1 on issue 3005 by nano...@gmail.com: timezone string limited to 20 char whereas some timezones are greater than 20 http://code.google.com/p/reviewboard/issues/detail?id=3005 the biggest string length is 30 chars for America/Argentina/Buenos_Aires import pytz max=0 for tz in pytz.common_timezones: ... if len(tz) > max: ... max=len(tz) ... print "%d %s" % (len(tz), tz) ... 14 Africa/Abidjan 18 Africa/Addis_Ababa 20 Africa/Dar_es_Salaam 30 America/Argentina/Buenos_Aires -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
Issue 3005 in reviewboard: timezone string limited to 20 char whereas some timezones are greater than 20
Status: New
Owner:
Labels: Type-Defect Priority-Medium
New issue 3005 by nano...@gmail.com: timezone string limited to 20 char
whereas some timezones are greater than 20
http://code.google.com/p/reviewboard/issues/detail?id=3005
*** For customer support, please post to reviewbo...@googlegroups.com
*** If you have a patch, please submit it to
http://reviews.reviewboard.org/
***
*** Do not post confidential information in this bug report!
What version are you running?
1.7.6 reviewboard server
What's the URL of the page containing the problem?
REVIEWBOARD_SERVER/account/preferences/
What steps will reproduce the problem?
1. change default timezone to America/Indiana/Indianapolis
2. no error reported but "America/Indiana/Indi" is saved in database
3. try to login and error 500 appears or try to change in admin section =>
Ensure this value has at most 20 characters (it has 28)
What is the expected output? What do you see instead?
saved value should not be stripped => "America/Indiana/Indianapolis"
What operating system are you using? What browser?
any
timezone evolution adds a string fixed to 20 chars
https://github.com/reviewboard/reviewboard/blob/master/reviewboard/accounts/evolutions/timezone.py
AddField('Profile', 'timezone', models.CharField, initial=u'UTC',
max_length=20)
it is also limited to 20 chars in model
https://github.com/reviewboard/reviewboard/blob/master/reviewboard/accounts/models.py
# Allows per-user timezone settings
timezone = models.CharField(choices=TIMEZONE_CHOICES, default='UTC',
max_length=20)
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
--
You received this message because you are subscribed to the Google Groups
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.
