Re: Issue 3024 in reviewboard: Enhance Review Board RBTools (rbt) to support svn tree (or file copy)

2013-08-12 Thread reviewboard

Updates:
Status: Fixed

Comment #5 on issue 3024 by trowb...@gmail.com: Enhance Review Board  
RBTools (rbt) to support svn tree (or file copy)

http://code.google.com/p/reviewboard/issues/detail?id=3024

Pushed to rbtools master (78715e4). Thanks!

--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/groups/opt_out.




Re: Issue 3024 in reviewboard: Enhance Review Board RBTools (rbt) to support svn tree (or file copy)

2013-07-08 Thread reviewboard


Comment #4 on issue 3024 by sudhir.s...@gmail.com: Enhance Review Board  
RBTools (rbt) to support svn tree (or file copy)

http://code.google.com/p/reviewboard/issues/detail?id=3024

Please review and I would be glad to do necessary changes.
http://reviews.reviewboard.org/r/4279/

--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/groups/opt_out.




Re: Issue 3024 in reviewboard: Enhance Review Board RBTools (rbt) to support svn tree (or file copy)

2013-07-02 Thread reviewboard


Comment #3 on issue 3024 by chip...@gmail.com: Enhance Review Board RBTools  
(rbt) to support svn tree (or file copy)

http://code.google.com/p/reviewboard/issues/detail?id=3024

Thanks, but we require that all patches go up for review at  
http://reviews.reviewboard.org/


--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/groups/opt_out.




Re: Issue 3024 in reviewboard: Enhance Review Board RBTools (rbt) to support svn tree (or file copy)

2013-07-01 Thread reviewboard


Comment #1 on issue 3024 by sudhir.s...@gmail.com: Enhance Review Board  
RBTools (rbt) to support svn tree (or file copy)

http://code.google.com/p/reviewboard/issues/detail?id=3024

Missed patch to utils/diffs.py file. Adding ...

--- 0.5.1.1/utils/diffs.py  (revision 408105)
+++ 0.5.1.1/utils/diffs.py  (working copy)
@@ -1,14 +1,16 @@
-def get_diff(scmtool, repository_info, revision_range=None,
- svn_changelist=None, files=[]):
+def get_diff(scmtool, repository_info, svn_show_copies_as_adds=None,
+ revision_range=None, svn_changelist=None, files=[]):
 Returns a diff as a string.
 if revision_range:
 diff, parent_diff = scmtool.diff_between_revisions(
 revision_range,
 files,
-repository_info)
+repository_info,
+svn_show_copies_as_adds)
 elif svn_changelist:
-diff, parent_diff = scmtool.diff_changelist(svn_changelist)
+diff, parent_diff = scmtool.diff_changelist(svn_changelist,
+ 
svn_show_copies_as_adds)

 else:
-diff, parent_diff = scmtool.diff(files)
+diff, parent_diff = scmtool.diff(files, svn_show_copies_as_adds)


Attachments:
patch  6.6 KB

--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/groups/opt_out.




Issue 3024 in reviewboard: Enhance Review Board RBTools (rbt) to support svn tree (or file copy)

2013-06-27 Thread reviewboard

Status: New
Owner: 
Labels: Type-Enhancement Priority-Medium

New issue 3024 by sudhir.s...@gmail.com: Enhance Review Board RBTools (rbt)  
to support svn tree (or file copy)

http://code.google.com/p/reviewboard/issues/detail?id=3024

*** For customer support, please post to reviewbo...@googlegroups.com
*** If you have a patch, please submit it to
http://reviews.reviewboard.org/
***
*** Do not post confidential information in this enhancement request!


What version are you running?
RBTools 0.5.1


Describe the enhancement and the motivation for it.
RBTools does NOT support svn tree copy (or file/files copy) from other  
branches.



Please provide any additional information below.
Please find attached patch.  With patch applied, rbt notifies user that it  
has detected tree/file copy and asks the user to


sudhirbs@rhel-sudhirbs usbrdl $ svn st
A  +my_dir


sudhirbs@rhel-sudhirbs $ rbt post
One or more files in your changeset has history scheduled with commit.
Please add option '--svn-show-copies-as-adds=y/n' and re-run

sudhirbs@rhel-sudhirbs $ rbt post --svn-show-copies-as-adds=y
Review request #14493 posted.


Attachments:
patch  5.5 KB

--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/groups/opt_out.