Re: Issue 3149 in reviewboard: reviewboard doesn't use sender email setting
Comment #5 on issue 3149 by leo.shkl...@gmail.com: reviewboard doesn't use sender email setting http://code.google.com/p/reviewboard/issues/detail?id=3149 Fair. Thanks for considering the issue. Unfortunately, I can't filter on any text in the email itself since someone replying to it will contain the same text. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/groups/opt_out.
Re: Issue 3149 in reviewboard: reviewboard doesn't use sender email setting
Comment #4 on issue 3149 by chip...@gmail.com: reviewboard doesn't use sender email setting http://code.google.com/p/reviewboard/issues/detail?id=3149 We won't be doing the incorrect thing, since that'll just lead to more confusion for users, issues in environments where different e-mail clients are used, and a massive support nightmare for us. This really needs to be fixed on the gmail side of things. Maybe try adding "This is an automatically generated e-mail" to your filter, for the content? -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/groups/opt_out.
Re: Issue 3149 in reviewboard: reviewboard doesn't use sender email setting
Comment #3 on issue 3149 by leo.shkl...@gmail.com: reviewboard doesn't use sender email setting http://code.google.com/p/reviewboard/issues/detail?id=3149 Thanks for the response. You're correct about the RFC. I re-read the reviewboard doc I linked to and it's a little confusing. With respect to filtering in gmail, neither of the approaches you're using work for us. Reviews are sent to some set of individuals rather than one list for the company so #1 doesn't work and #2 doesn't work since it would also capture people manually replying to the emails. Given that gmail is probably a pretty significant percentage of reviewboard users, it might be worth adding an option to workaround this issue and do the "incorrect" value for the From. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/groups/opt_out.
Re: Issue 3149 in reviewboard: reviewboard doesn't use sender email setting
Updates: Status: NotABug Comment #2 on issue 3149 by chip...@gmail.com: reviewboard doesn't use sender email setting http://code.google.com/p/reviewboard/issues/detail?id=3149 As per RFC 2822, and the Sender Policy Framework spec (RFC 4408) the Sender field should be the address of the agent sending the message (the server, so f...@bar.com in your example), and From should be the address of the author of the message (whether manually sent by them, or by a service on their behalf -- u...@bar.com). So, we're doing the correct thing. The issue of filtering in gmail is separate. What I personally do is filter two things: 1) The destination address (assuming e-mails are being sent to a specific reviews list), and 2) "Review Request" in the subject. It's not ideal, and I wish gmail would add support for filtering on other headers, but that's a bug to file against them. We're operating according to spec, whereas for a brief time in 1.6.x, we had a bug that swapped these values. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/groups/opt_out.
Re: Issue 3149 in reviewboard: reviewboard doesn't use sender email setting
Comment #1 on issue 3149 by leo.shkl...@gmail.com: reviewboard doesn't use sender email setting http://code.google.com/p/reviewboard/issues/detail?id=3149 Just upgraded to 1.7.19 - this is still an issue - the Sender header now says "f...@bar.com" but the From is still "u...@bar.com". Unfortunately there's no way to filter on Sender in gmail. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/groups/opt_out.
Issue 3149 in reviewboard: reviewboard doesn't use sender email setting
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 3149 by leo.shkl...@gmail.com: reviewboard doesn't use sender email setting http://code.google.com/p/reviewboard/issues/detail?id=3149 *** READ THIS BEFORE POSTING! *** *** You must complete this form in its entirety, or your bug report will be rejected. *** *** For customer support, please post to reviewbo...@googlegroups.com *** *** If you have a patch, please submit it to http://reviews.reviewboard.org/ *** *** Do not post confidential information in this bug report! What version are you running? 1.7.12 What's the URL of the page containing the problem? N/A What steps will reproduce the problem? 1. Set email sender to f...@bar.com in admin 2. Do reviewboard action as u...@bar.com that's triggered to send email 3. What is the expected output? What do you see instead? Expected: mail has a From header of f...@bar.com Instead: mail has a From header that says u...@bar.com This behavior worked properly as per - http://www.reviewboard.org/docs/manual/dev/admin/configuration/email-settings/#sender-email-address - in 1.6.X What operating system are you using? What browser? N/A Please provide any additional information below. The new behavior creates a real problem in gmail as there's no way using gmail's filtering to tell apart an auto-generated email from reviewboard and one that's sent by a human in response (or followup). With the behavior as documented, one could look for the From address to come out of ReviewBoard. Unfortunately, there's no way in gmail to filter on the other headers that identify the email as an automatically generated one. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/groups/opt_out.
