Re: Issue 3163 in reviewboard: --guess-summary should always use the first unpushed commit message from the branch.

2014-01-29 Thread reviewboard

Updates:
Status: Fixed

Comment #3 on issue 3163 by trowb...@gmail.com: --guess-summary should  
always use the first unpushed commit message from the branch.

http://code.google.com/p/reviewboard/issues/detail?id=3163

Fixed in rbtools master (b28c708). This will ship with 0.6

--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/groups/opt_out.


Issue 3163 in reviewboard: --guess-summary should always use the first unpushed commit message from the branch.

2013-12-09 Thread reviewboard

Status: New
Owner: 
Labels: Type-Enhancement Priority-Medium

New issue 3163 by fishp...@gmail.com: --guess-summary should always use the  
first unpushed commit message from the branch.

http://code.google.com/p/reviewboard/issues/detail?id=3163

What version are you running?
Review Board 1.7.11
RBTools 0.5.2

What's the URL of the page this enhancement relates to, if any?
N/A

Describe the enhancement and the motivation for it.
When I have already made a review and use post-review to post an update to  
the review, it always changes the summary message to my latest commit  
message.  This usually doesn't make sense since my initial commit is more  
informative as a summary and the trailing commits are usually whitespace  
and grammar fixes.  --guess-summary should either not update the summary of  
an existing review or always use the first unpushed commit message from the  
branch.


What operating system are you using? What browser?
Firefox 25.0

Please provide any additional information below.
I am dealing with this issue because my system has GUESS_SUMMARY=1 set in  
the .reviewboardrc by our compliance system. I can't just turn it off, even  
though I would like to because it gets re-enabled immediately.  I have been  
working around this by manually editing the summary after posting, or with  
squashing when it is a smaller commit.  I still think that logically the  
guess would be more accurate when pulling in from the first commit message  
when guessing the summary.


--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/groups/opt_out.