Re: Issue 3309 in reviewboard: Really long comment causes unreadable review

2014-07-06 Thread reviewboard


Comment #5 on issue 3309 by chip...@gmail.com: Really long comment causes  
unreadable review

http://code.google.com/p/reviewboard/issues/detail?id=3309

Issue 3466 has been merged into this issue.

--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Re: Issue 3309 in reviewboard: Really long comment causes unreadable review

2014-06-25 Thread reviewboard


Comment #4 on issue 3309 by chip...@gmail.com: Really long comment causes  
unreadable review

http://code.google.com/p/reviewboard/issues/detail?id=3309

Issue 3443 has been merged into this issue.

--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Re: Issue 3309 in reviewboard: Really long comment causes unreadable review

2014-06-21 Thread reviewboard

Updates:
Status: Fixed

Comment #3 on issue 3309 by chip...@gmail.com: Really long comment causes  
unreadable review

http://code.google.com/p/reviewboard/issues/detail?id=3309

Fixed on release-2.0.x (49c378b)

--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Re: Issue 3309 in reviewboard: Really long comment causes unreadable review

2014-06-20 Thread reviewboard


Comment #1 on issue 3309 by chip...@gmail.com: Really long comment causes  
unreadable review

http://code.google.com/p/reviewboard/issues/detail?id=3309

Issue 3375 has been merged into this issue.

--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Issue 3309 in reviewboard: Really long comment causes unreadable review

2014-04-16 Thread reviewboard

Status: New
Owner: 
Labels: Type-Defect Priority-Medium

New issue 3309 by nlasso...@landmarkglobal.com: Really long comment causes  
unreadable review

http://code.google.com/p/reviewboard/issues/detail?id=3309

*** READ THIS BEFORE POSTING!
***
*** You must complete this form in its entirety, or your bug report will be
rejected.
***
*** For customer support, please post to reviewbo...@googlegroups.com
***
*** If you have a patch, please submit it to
http://reviews.reviewboard.org/
***
*** Do not post confidential information in this bug report!


What version are you running?

2.0 RC2

What's the URL of the page containing the problem?

/r/10/diff/#

What steps will reproduce the problem?
1. Create code with a really long comment line. Like, really long.
2. Create a review which involves that line, such as deleting or moving it.

What is the expected output? What do you see instead?

I expect the really long line will be wrapped. Or worst case, a horizontal  
scrollbar.


Instead, the box for the updated file is unreadably small *and* has data  
cut off. See screen-shot. There is no scroll bar.


What operating system are you using? What browser?

Reproduced on Mac OS X Chrome and Ubuntu Firefox.

Please provide any additional information below.

In my installation I added a solution by adding a CSS attribute:

.sidebyside pre {
   max-width: 50vw;
}

This makes each side of the review be no more than 50% of the browser  
window, which prevents this problem. You may solve it that way or maybe  
have another way that you would prefer to solve it.


Attachments:
Screen Shot 2014-04-16 at 2.52.03 PM.png  111 KB

--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.