Re: Issue 3408 in reviewboard: ReviewBoard 2.0.1 - RB is undefined error on IE8
Updates: Status: WontFix Comment #6 on issue 3408 by trowb...@gmail.com: ReviewBoard 2.0.1 - RB is undefined error on IE8 http://code.google.com/p/reviewboard/issues/detail?id=3408 (No comment was entered for this change.) -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Issue 3408 in reviewboard: ReviewBoard 2.0.1 - RB is undefined error on IE8
Comment #5 on issue 3408 by chip...@gmail.com: ReviewBoard 2.0.1 - RB is undefined error on IE8 http://code.google.com/p/reviewboard/issues/detail?id=3408 So that being said, I spent a few minutes with this. Adding those PIPELINE_MIMETYPES and then dropping in es5-shim.min.js (https://github.com/es-shims/es5-shim) seems to allow it to function. It does, however, fail 120 of our unit tests, with no useful errors, and it's very slow. So, we still won't officially support it, but you can play with it, and I'll accept reasonable patches to get things working. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Issue 3408 in reviewboard: ReviewBoard 2.0.1 - RB is undefined error on IE8
Comment #4 on issue 3408 by chip...@gmail.com: ReviewBoard 2.0.1 - RB is undefined error on IE8 http://code.google.com/p/reviewboard/issues/detail?id=3408 Unfortunately, too many things we depend on do not support IE8. It's just, at this point, too old, too broken a browser, and one we've dropped support for. Can your company upgrade to anything modern? -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Issue 3408 in reviewboard: ReviewBoard 2.0.1 - RB is undefined error on IE8
Comment #3 on issue 3408 by ke...@keithmoyer.com: ReviewBoard 2.0.1 - RB is undefined error on IE8 http://code.google.com/p/reviewboard/issues/detail?id=3408 If I add PIPELINE_MIMETYPES = ( (b'text/coffeescript', '.coffee'), (b'text/less', '.less'), (b'text/javascript', '.js'), (b'text/x-sass', '.sass'), (b'text/x-scss', '.scss') ) to my settings_local.py (the newer django pipelines defaults to application/javascript, which IE8 doesn't like), I get further but still fail: 'XMLHttpRequest.prototype' is null or not an object base.min.9bf67e7ea227.js, line 1 character 12697 'XMLHttpRequest.prototype' is null or not an object base.min.9bf67e7ea227.js, line 1 character 12697 'RB.UserSession' is null or not an object diff, line 421 character 5 'RB.UserSession' is null or not an object diff, line 421 character 5 'RB.ReviewRequest.CLOSE_DISCARDED' is null or not an object reviews.min.00ba5bbcb4cb.js, line 3 character 31396 'RB.ReviewRequest.CLOSE_DISCARDED' is null or not an object reviews.min.00ba5bbcb4cb.js, line 3 character 31396 'RB.PageManager' is null or not an object diff, line 434 character 5 'RB.PageManager' is null or not an object diff, line 434 character 5 -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Issue 3408 in reviewboard: ReviewBoard 2.0.1 - RB is undefined error on IE8
Comment #2 on issue 3408 by ke...@keithmoyer.com: ReviewBoard 2.0.1 - RB is
undefined error on IE8
http://code.google.com/p/reviewboard/issues/detail?id=3408
Also seeing this here. Works fine in Firefox 29 and Chrome 32
'RB' is undefined: diff, line 442 character 5
'RB' is undefined: diff, line 455 character 5
Those line correspond to
RB.UserSession.create({
authenticated: false,
loginURL: "/account/login/"
});
and
RB.PageManager.setPage(new RB.DiffViewerPageView({
...
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
--
You received this message because you are subscribed to the Google Groups
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.
Re: Issue 3408 in reviewboard: ReviewBoard 2.0.1 - RB is undefined error on IE8
Updates: Status: NeedInfo Comment #1 on issue 3408 by chip...@gmail.com: ReviewBoard 2.0.1 - RB is undefined error on IE8 http://code.google.com/p/reviewboard/issues/detail?id=3408 I can't reproduce this. Can you provide the full JavaScript error log? Do you see this with any other browsers on that system? -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Issue 3408 in reviewboard: ReviewBoard 2.0.1 - RB is undefined error on IE8
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 3408 by roma.koi...@gmail.com: ReviewBoard 2.0.1 - RB is undefined error on IE8 http://code.google.com/p/reviewboard/issues/detail?id=3408 *** READ THIS BEFORE POSTING! *** *** You must complete this form in its entirety, or your bug report will be *** rejected. *** *** If you have a security issue to report, please send it confidentially to *** secur...@reviewboard.org. Posting security-related issues to this bug *** tracker causes us to have to do an emergency release. *** *** For customer support, please post to reviewbo...@googlegroups.com *** *** If you have a patch, please submit it to http://reviews.reviewboard.org/ *** *** This bug tracker is public. Please check that any logs or other information *** that you include has been stripped of confidential information. What version are you running? Review Board - 2.0.1 What's the URL of the page containing the problem? http:///r/125/ What steps will reproduce the problem? 1. post review request using rbt 2. open review request 3. What is the expected output? What do you see instead? I can't see the diffs. Instead the error 'RB' is undefined is shown by IE. What operating system are you using? What browser? Windows 7 IE 8 Please provide any additional information below. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
