Re: Issue 3413 in reviewboard: Uploading invalid diff to existing review results in Loading... hang
Updates: Status: Fixed Comment #5 on issue 3413 by trowb...@gmail.com: Uploading invalid diff to existing review results in Loading... hang http://code.google.com/p/reviewboard/issues/detail?id=3413 Fixed in release-2.0.x (76caaa7). Thanks! -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Issue 3413 in reviewboard: Uploading invalid diff to existing review results in Loading... hang
Comment #3 on issue 3413 by mcan...@coveo.com: Uploading invalid diff to existing review results in Loading... hang http://code.google.com/p/reviewboard/issues/detail?id=3413 I have the same problems with reviewboard 2.0.2. Chrome 35 and 36 on windows 7. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Issue 3413 in reviewboard: Uploading invalid diff to existing review results in Loading... hang
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 3413 by bruce.c...@gmail.com: Uploading invalid diff to existing review results in Loading... hang http://code.google.com/p/reviewboard/issues/detail?id=3413 What version are you running? 2.0.1 What's the URL of the page containing the problem? https://reviews/r/1234 What steps will reproduce the problem? 1. Create a new, valid review. 2. Select Update - Update Diff 3. Select a diff which doesn't apply (wrong repository, source revision doesn't exist etc.) What is the expected output? What do you see instead? An error should be displayed. Instead, the 'Loading...' spinner appears and never stops. If an attempt is made to create a *new* review using the diff, the expected error message is displayed. What operating system are you using? What browser? Windows 8.1 and Firefox 30. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Issue 3413 in reviewboard: Uploading invalid diff to existing review results in Loading... hang
Comment #1 on issue 3413 by abhishek.mukher.g: Uploading invalid diff to existing review results in Loading... hang http://code.google.com/p/reviewboard/issues/detail?id=3413 We're experiencing similar problems. If you open the network inspector in chrome you can see that the response comes back as a 400 correctly so it's in the javascript -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Issue 3413 in reviewboard: Uploading invalid diff to existing review results in Loading... hang
Comment #2 on issue 3413 by bruce.c...@gmail.com: Uploading invalid diff to
existing review results in Loading... hang
http://code.google.com/p/reviewboard/issues/detail?id=3413
I wonder if this is at all related to
https://code.google.com/p/reviewboard/issues/detail?id=3338 ('Upload Diff'
allows user to click button without choosing diffs)? I noticed the fix
didn't make it into version 2.0.1.
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
--
You received this message because you are subscribed to the Google Groups
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.
