Re: Issue 3505 in reviewboard: Empty drafts can be submitted
Updates: Status: Fixed Comment #6 on issue 3505 by trowb...@gmail.com: Empty drafts can be submitted https://code.google.com/p/reviewboard/issues/detail?id=3505 Fixed in release-2.0.x (e192efe). Thanks! -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Issue 3505 in reviewboard: Empty drafts can be submitted
Comment #5 on issue 3505 by akiyam...@gmail.com: Empty drafts can be submitted https://code.google.com/p/reviewboard/issues/detail?id=3505 Can I work on this one? I think I can try on it . Chenxi -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Issue 3505 in reviewboard: Empty drafts can be submitted
Updates: Labels: -Type-Defect Type-Enhancement Comment #3 on issue 3505 by trowb...@gmail.com: Empty drafts can be submitted http://code.google.com/p/reviewboard/issues/detail?id=3505 (No comment was entered for this change.) -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Issue 3505 in reviewboard: Empty drafts can be submitted
Comment #2 on issue 3505 by anhi...@cisco.com: Empty drafts can be submitted http://code.google.com/p/reviewboard/issues/detail?id=3505 I agree that it's not a regression. Could we make it a feature request? I'd like to be able to specify validation steps to move between states. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Issue 3505 in reviewboard: Empty drafts can be submitted
Updates: Status: Confirmed Labels: -Priority-Medium Priority-Low Component-Reviews Comment #1 on issue 3505 by chip...@gmail.com: Empty drafts can be submitted http://code.google.com/p/reviewboard/issues/detail?id=3505 This happens because the submitted state is just a flag, and doesn't deal with drafts (and therefore field validation). We don't require anything for a submitted review request. That doesn't mean it's ideal, but fortunately, it's not a regression, from what I can tell. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Issue 3505 in reviewboard: Empty drafts can be submitted
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 3505 by anhi...@cisco.com: Empty drafts can be submitted http://code.google.com/p/reviewboard/issues/detail?id=3505 *** READ THIS BEFORE POSTING! *** *** You must complete this form in its entirety, or your bug report will be *** rejected. *** *** If you have a security issue to report, please send it confidentially to *** secur...@reviewboard.org. Posting security-related issues to this bug *** tracker causes us to have to do an emergency release. *** *** For customer support, please post to reviewbo...@googlegroups.com *** *** If you have a patch, please submit it to http://reviews.reviewboard.org/ *** *** This bug tracker is public. Please check that any logs or other information *** that you include has been stripped of confidential information. What version are you running? e625b89 What's the URL of the page containing the problem? /r/N/ for any review request N with an unpublished draft What steps will reproduce the problem? 1. Create a new review request and don't fill out any fields 2. Choose Close->Submitted from the menu on the top right What is the expected output? What do you see instead? When attempting to publish a draft with missing fields, error dialogs prevent it. However, this can be circumvented by submitting the review request (and reopening it, if desired). What operating system are you using? What browser? N/A Please provide any additional information below. I came across this while trying to figure out how to validate extra fields for an extension, but I can't see how any fields are validated aside from a few JavaScript barriers. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
