Re: Issue 3512 in reviewboard: Cannot add SSL Perforce repository

2014-08-31 Thread reviewboard


Comment #8 on issue 3512 by mohyedeen: Cannot add SSL Perforce repository
https://code.google.com/p/reviewboard/issues/detail?id=3512

I applied this fix locally, it works.
I was able to add SSL P4 repository
Now I am facing a problem where when you rbt setup-repo you have to have a  
mirror path to match with P4 info.
the server path for P4 sometimes will have something like Server address:  
ip-00-000-0-00.ec2.internal:1666
So in order to be able to add a repo for rbt you have to have such a thing  
in mirror path
Now this produce an issue when you try to post a review, where it try to  
use this IP to query the diff


To get unblocked I had to remove repository.mirror_path from line 272
maybe we you should include this only when it have a valid address.

--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Re: Issue 3512 in reviewboard: Cannot add SSL Perforce repository

2014-08-31 Thread reviewboard


Comment #9 on issue 3512 by mohyedeen: Cannot add SSL Perforce repository
https://code.google.com/p/reviewboard/issues/detail?id=3512

I applied this fix locally, it works.
I was able to add SSL P4 repository
Now I am facing a problem where when you rbt setup-repo you have to have a  
mirror path to match with P4 info.
the server path for P4 sometimes will have something like Server address:  
ip-00-000-0-00.ec2.internal:1666
So in order to be able to add a repo for rbt you have to have such a thing  
in mirror path
Now this produce an issue when you try to post a review, where it try to  
use this IP to query the diff


To get unblocked I had to remove repository.mirror_path from line 272
maybe you should include this only when it have a valid address.

--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Re: Issue 3512 in reviewboard: Cannot add SSL Perforce repository

2014-08-27 Thread reviewboard


Comment #6 on issue 3512 by mohyedeen: Cannot add SSL Perforce repository
https://code.google.com/p/reviewboard/issues/detail?id=3512

Thank you, just verified the fixed, its working.
When I added the perforce repo, I went to dashboard to create a review, but  
I wasnt able to see any of the commits to pick from and create a review  
(unlike github repo, it shows all of the commits.) Is this by design?


--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Re: Issue 3512 in reviewboard: Cannot add SSL Perforce repository

2014-08-27 Thread reviewboard


Comment #7 on issue 3512 by trowb...@gmail.com: Cannot add SSL Perforce  
repository

https://code.google.com/p/reviewboard/issues/detail?id=3512

The post-commit UI feature is currently only available for GitHub and SVN  
repositories. Support for more will be coming in the future.


--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Re: Issue 3512 in reviewboard: Cannot add SSL Perforce repository

2014-08-26 Thread reviewboard

Updates:
Status: Fixed

Comment #5 on issue 3512 by trowb...@gmail.com: Cannot add SSL Perforce  
repository

https://code.google.com/p/reviewboard/issues/detail?id=3512

Fixed in release-2.0.x (fda8dd5). Thanks!

--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Re: Issue 3512 in reviewboard: Cannot add SSL Perforce repository

2014-08-25 Thread reviewboard

Updates:
Status: Confirmed
Owner: trowb...@gmail.com
Labels: Component-SCMTools Project-ReviewBoard

Comment #4 on issue 3512 by trowb...@gmail.com: Cannot add SSL Perforce  
repository

https://code.google.com/p/reviewboard/issues/detail?id=3512

Thanks for the traceback! We'll get this fixed for the next release.

--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Re: Issue 3512 in reviewboard: Cannot add SSL Perforce repository

2014-08-23 Thread reviewboard


Comment #2 on issue 3512 by mohyedeen: Cannot add SSL Perforce repository
https://code.google.com/p/reviewboard/issues/detail?id=3512

Yes here is what I have in the log

 - Exception thrown for user admin at  
http://localhost/admin/db/scmtools/repository/1/


accept_certificate() got an unexpected keyword argument 'username'
Traceback (most recent call last):
   
File /usr/lib/python2.7/site-packages/Django-1.6.6-py2.7.egg/django/core/handlers/base.py,  
line 112, in get_response

response = wrapped_callback(request, *callback_args, **callback_kwargs)
   
File /usr/lib/python2.7/site-packages/Django-1.6.6-py2.7.egg/django/contrib/admin/options.py,  
line 450, in wrapper

return self.admin_site.admin_view(view)(*args, **kwargs)
   
File /usr/lib/python2.7/site-packages/Django-1.6.6-py2.7.egg/django/utils/decorators.py,  
line 99, in _wrapped_view

response = view_func(request, *args, **kwargs)
   
File /usr/lib/python2.7/site-packages/Django-1.6.6-py2.7.egg/django/views/decorators/cache.py,  
line 52, in _wrapped_view_func

response = view_func(request, *args, **kwargs)
   
File /usr/lib/python2.7/site-packages/Django-1.6.6-py2.7.egg/django/contrib/admin/sites.py,  
line 198, in inner

return view(request, *args, **kwargs)
   
File /usr/lib/python2.7/site-packages/Django-1.6.6-py2.7.egg/django/utils/decorators.py,  
line 29, in _wrapper

return bound_func(*args, **kwargs)
   
File /usr/lib/python2.7/site-packages/Django-1.6.6-py2.7.egg/django/utils/decorators.py,  
line 99, in _wrapped_view

response = view_func(request, *args, **kwargs)
   
File /usr/lib/python2.7/site-packages/Django-1.6.6-py2.7.egg/django/utils/decorators.py,  
line 25, in bound_func

return func(self, *args2, **kwargs2)
   
File /usr/lib/python2.7/site-packages/Django-1.6.6-py2.7.egg/django/db/transaction.py,  
line 371, in inner

return func(*args, **kwargs)
   
File /usr/lib/python2.7/site-packages/Django-1.6.6-py2.7.egg/django/contrib/admin/options.py,  
line 1229, in change_view

if form.is_valid():
   
File /usr/lib/python2.7/site-packages/ReviewBoard-2.0.6-py2.7.egg/reviewboard/scmtools/forms.py,  
line 1024, in is_valid

if not super(RepositoryForm, self).is_valid():
   
File /usr/lib/python2.7/site-packages/Django-1.6.6-py2.7.egg/django/forms/forms.py,  
line 129, in is_valid

return self.is_bound and not bool(self.errors)
   
File /usr/lib/python2.7/site-packages/Django-1.6.6-py2.7.egg/django/forms/forms.py,  
line 121, in errors

self.full_clean()
   
File /usr/lib/python2.7/site-packages/ReviewBoard-2.0.6-py2.7.egg/reviewboard/scmtools/forms.py,  
line 813, in full_clean

super(RepositoryForm, self).full_clean()
   
File /usr/lib/python2.7/site-packages/Django-1.6.6-py2.7.egg/django/forms/forms.py,  
line 274, in full_clean

self._clean_form()
   
File /usr/lib/python2.7/site-packages/Django-1.6.6-py2.7.egg/django/forms/forms.py,  
line 300, in _clean_form

self.cleaned_data = self.clean()
   
File /usr/lib/python2.7/site-packages/ReviewBoard-2.0.6-py2.7.egg/reviewboard/scmtools/forms.py,  
line 862, in clean

self._verify_repository_path()
   
File /usr/lib/python2.7/site-packages/ReviewBoard-2.0.6-py2.7.egg/reviewboard/scmtools/forms.py,  
line 1194, in _verify_repository_path

certificate=e.certificate)
TypeError: accept_certificate() got an unexpected keyword  
argument 'username'



--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Re: Issue 3512 in reviewboard: Cannot add SSL Perforce repository

2014-08-23 Thread reviewboard


Comment #3 on issue 3512 by mohyedeen: Cannot add SSL Perforce repository
https://code.google.com/p/reviewboard/issues/detail?id=3512

I did just upgrade to 2.0.6, but its pretty much the same issue in 2.0.5

--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Re: Issue 3512 in reviewboard: Cannot add SSL Perforce repository

2014-08-19 Thread reviewboard

Updates:
Status: NeedInfo

Comment #1 on issue 3512 by trowb...@gmail.com: Cannot add SSL Perforce  
repository

http://code.google.com/p/reviewboard/issues/detail?id=3512

Can you check the reviewboard log files to see if there's anything in there?

--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.