Re: Issue 3654 in reviewboard: HTML anchors in File Index not working for copied files
Updates: Status: Fixed Owner: chip...@gmail.com Comment #7 on issue 3654 by chip...@gmail.com: HTML anchors in File Index not working for copied files https://code.google.com/p/reviewboard/issues/detail?id=3654 Fixed on release-2.0.x (bf7d9de) -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Issue 3654 in reviewboard: HTML anchors in File Index not working for copied files
Comment #6 on issue 3654 by griffin@gmail.com: HTML anchors in File
Index not working for copied files
https://code.google.com/p/reviewboard/issues/detail?id=3654
I wanted to follow up with a few more details. I'm using Subversion and it
appears that this issue may be SCM dependent. Attempting to emulate the
problem under git with a trivial file move does not exhibit the problem,
whereas SVN with a trivial file copy does.
Looking at the SVN case, the filediff related metadata (is_new_file, moved,
copied, etc.) generated in get_diff_files() from
reviewboard/diffviewer/diffutils.py does not seem necessarily correct. I
don't know if this points to a larger problem, or if this is expected for
SVN. For the trivial copied file case this looks like:
{u'force_interdiff': False, u'binary': False, u'interfilediff': None,
u'dest_revision': u'New File', u'deleted': False, u'index': 0, u'moved':
False, u'moved_or_copied': False, u'chunks_loaded': False,
u'depot_filename': u'trunk/a.txt', u'dest_filename':
u'trunk/dir1/copied_file.txt', u'is_new_file': True, u'newfile': True,
u'copied': False, u'filediff': FileDiff: trunk/a.txt (PRE-CREATION) -
trunk/dir1/copied_file.txt ((working copy)), u'revision': u''}
Extending this to the if block on lines 77-79 of diff_file_fragment.html,
since not file.is_new_file is false the anchor name is not set even
though the filename subsequently produced on line 80 needs an anchor name.
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
--
You received this message because you are subscribed to the Google Groups
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.
Re: Issue 3654 in reviewboard: HTML anchors in File Index not working for copied files
Comment #3 on issue 3654 by cmur...@gmail.com: HTML anchors in File Index not working for copied files https://code.google.com/p/reviewboard/issues/detail?id=3654 I'm looking in to this! -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Issue 3654 in reviewboard: HTML anchors in File Index not working for copied files
Comment #2 on issue 3654 by cmur...@gmail.com: HTML anchors in File Index not working for copied files https://code.google.com/p/reviewboard/issues/detail?id=3654 I'm looking in to this! -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Issue 3654 in reviewboard: HTML anchors in File Index not working for copied files
Comment #4 on issue 3654 by rmeringe...@gmail.com: HTML anchors in File Index not working for copied files https://code.google.com/p/reviewboard/issues/detail?id=3654 Tried to Reproduce error in release-2.0.x branch and wasn't able to reproduce bug. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Issue 3654 in reviewboard: HTML anchors in File Index not working for copied files
Comment #5 on issue 3654 by griffin@gmail.com: HTML anchors in File
Index not working for copied files
https://code.google.com/p/reviewboard/issues/detail?id=3654
I can absolutely reproduce this in master with the built in development
webserver.
The issue appears to be on line 80 of
reviewboard/templates/diffviewer/diff_file_fragment.html. Adding a
name={{file.index}} class=file-anchor here, similar to how it appears
on line 78, fixes the problem. However, I don't understand the surrounding
code well enough to know if this is a sufficient solution. Particularly,
it seems like the code in the prior if block (lines 77-79), which does set
an anchor name, may be intended to work in conjunction with line 80 and
that is why 80 omits the anchor name.
Please let me know if you need me to provide additional details to
replicate this issue.
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
--
You received this message because you are subscribed to the Google Groups
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.
Issue 3654 in reviewboard: HTML anchors in File Index not working for copied files
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 3654 by griffin@gmail.com: HTML anchors in File Index not working for copied files https://code.google.com/p/reviewboard/issues/detail?id=3654 What version are you running? 2.0.11 What's the URL of the page containing the problem? Any diff viewer page What steps will reproduce the problem? 1. Create a RR with copied/moved files. What is the expected output? What do you see instead? Expected: Clicking file name in File Index advances diff viewer to that file. Works as expected for deleted, modified, and new files. Actual: Does nothing for copied files (e.g. those marked with Was /old/path/name). Hovering over the hyperlink shows an anchor in the URL, but nothing happens when clicking the link What operating system are you using? What browser? Windows 7 Firefox 33.0 Internet Explorer 11.0.9600.17358 Please provide any additional information below. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
