Status: New
Owner: ----
Labels: Type-Defect Priority-Medium
New issue 3710 by mgul...@gmail.com: reviewboard diff viewer shows binary
file contents for unchanged perforce files
https://code.google.com/p/reviewboard/issues/detail?id=3710
*** READ THIS BEFORE POSTING!
***
*** You must complete this form in its entirety, or your bug report will be
*** rejected.
***
*** If you have a security issue to report, please send it confidentially
to
*** secur...@reviewboard.org. Posting security-related issues to this bug
*** tracker causes us to have to do an emergency release.
***
*** For customer support, please post to reviewbo...@googlegroups.com
***
*** If you have a patch, please submit it to
http://reviews.reviewboard.org/
***
*** This bug tracker is public. Please check that any logs or other
information
*** that you include has been stripped of confidential information.
What version are you running?
Reviewboard 2.0.8
What's the URL of the page containing the problem?
http://reviewboard/r/ID/diff/#
What steps will reproduce the problem?
1. Using an old version of rbtools (0.4.3)
2. p4 edit some_binary_file.gif
3. post-review
What is the expected output? What do you see instead?
The diff viewer should print that the file is unchanged.
Instead, it prints the binary contents of the file.
What operating system are you using? What browser?
Debian 7 (wheezy), Chrome 37
Please provide any additional information below.
This issue doesn't happen with newer rbtools, but that is because binary
files in Perforce seem to be completely ignored in the newer version of
rbtools (see http://code.google.com/p/reviewboard/issues/detail?id=3659)
If the binary contents differ, the diff will contain the line "Binary files
a and b differ", so reviewboard will know that the file is binary.
However, when the files are identical, no such line is included in the
diff. Instead, all that appears is the line:
==== //depot/file.gif#1 ==M== //depot/file.gif ====
This is no way to indicate to the reviewboard server that the file is
binary. It should be possible to find this from perforce itself (e.g. "p4
fstat FILE" indicates that the type is binary/xbinary).
To work around this issue, I'm adding the line "Binary files a and b
differ" to the diff for binary files that are identical.
Feel free to change this to an enhancement if you feel it does not qualify
as a defect.
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
--
You received this message because you are subscribed to the Google Groups
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.
