Re: Issue 3751 in reviewboard: RBTools leaks DB handles (& other resources?) in long-living process

2015-02-03 Thread reviewboard

Updates:
Status: Fixed

Comment #5 on issue 3751 by bar...@beanbaginc.com: RBTools leaks DB handles  
(& other resources?) in long-living process

https://code.google.com/p/reviewboard/issues/detail?id=3751

The fix for this has landed on both the release-0.7.x branch and the master  
branch.


--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Re: Issue 3751 in reviewboard: RBTools leaks DB handles (& other resources?) in long-living process

2015-02-03 Thread reviewboard

Updates:
Status: Confirmed

Comment #4 on issue 3751 by chip...@gmail.com: RBTools leaks DB handles (&  
other resources?) in long-living process

https://code.google.com/p/reviewboard/issues/detail?id=3751

We've discovered the problem and will get it into this week's release.

The problem was due to an atexit() call in rbtools/api/cache.py. You can  
find that line and remove it to prevent this problem on your server until  
you can upgrade.


--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Re: Issue 3751 in reviewboard: RBTools leaks DB handles (& other resources?) in long-living process

2015-02-03 Thread reviewboard


Comment #3 on issue 3751 by vlov...@gmail.com: RBTools leaks DB handles (&  
other resources?) in long-living process

https://code.google.com/p/reviewboard/issues/detail?id=3751

Sorry.  I thought I was running 0.6.2 but it was actually 0.7.

--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Re: Issue 3751 in reviewboard: RBTools leaks DB handles (& other resources?) in long-living process

2015-02-03 Thread reviewboard

Updates:
Status: NeedInfo
Owner: bar...@beanbaginc.com
Labels: Project-RBTools Milestone-RBTools-Release0.7.x

Comment #2 on issue 3751 by chip...@gmail.com: RBTools leaks DB handles (&  
other resources?) in long-living process

https://code.google.com/p/reviewboard/issues/detail?id=3751

0.6.x never had an API cache database. I just want to verify that the first  
reported version was an error.


--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Re: Issue 3751 in reviewboard: RBTools leaks DB handles (& other resources?) in long-living process

2015-02-03 Thread reviewboard


Comment #1 on issue 3751 by vlov...@gmail.com: RBTools leaks DB handles (&  
other resources?) in long-living process

https://code.google.com/p/reviewboard/issues/detail?id=3751

This reproduces with 0.7

--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Issue 3751 in reviewboard: RBTools leaks DB handles (& other resources?) in long-living process

2015-02-03 Thread reviewboard

Status: New
Owner: 
Labels: Type-Defect Priority-Medium

New issue 3751 by vlov...@gmail.com: RBTools leaks DB handles (& other  
resources?) in long-living process

https://code.google.com/p/reviewboard/issues/detail?id=3751

What version are you running?
RBTools 0.6.2

What's the URL of the page containing the problem?
N/A

What steps will reproduce the problem?
1. Update parameters of attached program to match your reviewboard  
credentials

2. Run attached program

What is the expected output? What do you see instead?
I expect only 1 connection to apicache.db since I only have 1 RBClient  
created which I tear down immediately.  Instead I see it keeps growing.   
There is no way to tear down this RBClient.


What operating system are you using? What browser?
Python 2.7, 10.10

Please provide any additional information below.
This causes a huge problem where we run out of FDs in a long-running  
process (buildbot) where we create a new connection on every build.  I can  
improve it slightly by trying to persist the client handle, but the problem  
is there's absolutely no way for me to tear down this resource.


Looking at the lsof, we see a *lot* of open file handles to  
~/Library/Caches/rbtools/apicache.db


Attachments:
test.py  270 bytes

--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.