Re: Issue 3774 in reviewboard: Active Directory login fails if group contains non-ascii characters

2015-02-23 Thread reviewboard

Updates:
Status: Fixed

Comment #2 on issue 3774 by trowb...@gmail.com: Active Directory login  
fails if group contains non-ascii characters

https://code.google.com/p/reviewboard/issues/detail?id=3774

Fixed in release-2.0.x (becc0fe). Thanks!

--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Re: Issue 3774 in reviewboard: Active Directory login fails if group contains non-ascii characters

2015-02-17 Thread reviewboard

Updates:
Status: PendingReview
Owner: trowb...@gmail.com
Labels: Component-Accounts

Comment #1 on issue 3774 by trowb...@gmail.com: Active Directory login  
fails if group contains non-ascii characters

https://code.google.com/p/reviewboard/issues/detail?id=3774

(No comment was entered for this change.)

--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Issue 3774 in reviewboard: Active Directory login fails if group contains non-ascii characters

2015-02-17 Thread reviewboard

Status: New
Owner: 
Labels: Type-Defect Priority-Medium

New issue 3774 by hanko.ge...@gmail.com: Active Directory login fails if  
group contains non-ascii characters

https://code.google.com/p/reviewboard/issues/detail?id=3774

What version are you running?
2.0.12

What's the URL of the page containing the problem?
confidential, not relevant


What steps will reproduce the problem?
1. user is in an AD group that contains non-ascii characters (e.g. é)
2. try to log in using Active Directory user name and password

What is the expected output? What do you see instead?
Expected:
successful sign-in
Actual:
-log-in issue with the usual error message on client side
-the following error is shown in log:
ERROR -  - Active Directory error: failed gettinggroups for  
user 'tgemes': 'ascii' codec can't decode byte 0xc3 in position 15: ordinal  
not in range(128)

Traceback (most recent call last):
   
File "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.12-py2.7.egg/reviewboard/accounts/backends.py",  
line 685, in authenticate

group_names = self.get_member_of(con, user_data)
   
File "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.12-py2.7.egg/reviewboard/accounts/backends.py",  
line 571, in get_member_of

new_groups = [x.split(',')[0].split('=')[1] for x in member_of]
UnicodeDecodeError: 'ascii' codec can't decode byte 0xc3 in position 15:  
ordinal not in range(128)


What operating system are you using? What browser?

Server is running on
Linux  3.13.0-43-generic #72-Ubuntu SMP Mon Dec 8  
19:35:06 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux

Server version: Apache/2.4.7 (Ubuntu)
Server built:   Jul 22 2014 14:36:38

The issue is browser-independent.

Please provide any additional information below.
Tried to set LANG environment variable to en_US.UTF-8 in  
/etc/apache2/envvars but it didn't help.
When the exception is caught for the problematic group the log-in is  
successful, but if the required group contains non-ascii characters this  
solution is not enough.


Please check this.

Best regards,
Gergely


--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.