Issue 772 in reviewboard: Lines of all whitespace should be ignored when creating diffs
Comment #2 on issue 772 by kyle.getz: Lines of all whitespace should be ignored when creating diffs http://code.google.com/p/reviewboard/issues/detail?id=772 Sure, that's fine. If you wanted to add a bit more concreteness to the rule, it could go something like: Lines containing all whitespace are OK, as long as the line is not indented further than the line above. If the line is indented further than the line above, then those extra spaces are marked in red. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 772 in reviewboard: Lines of all whitespace should be ignored when creating diffs
Comment #1 on issue 772 by chipx86: Lines of all whitespace should be ignored when creating diffs http://code.google.com/p/reviewboard/issues/detail?id=772 While we may be able to make this an optional thing down the road, right now the current behavior is by design. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 772 in reviewboard: Lines of all whitespace should be ignored when creating diffs
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 772 by kyle.getz: Lines of all whitespace should be ignored when creating diffs http://code.google.com/p/reviewboard/issues/detail?id=772 Describe the enhancement and the motivation for it. Currently, Review Board does not like lines containing all whitespace - those lines get marked with scary red blocks. If you use an editor that does auto-indenting (which I'm sure many people do), then inserting a blank line (by hitting Enter twice) is going to leave a line with all whitespace. I know Review Board marks trailing whitespace in red, but maybe that should be ignored when the entire line is whitespace? What operating system are you using? What browser? Windows XP Professional, Firefox 3 -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
