Issue 845 in reviewboard: AJAX_SERIAL causing diffs to not load

2009-02-03 Thread codesite-noreply


Comment #3 on issue 845 by jefflamb: AJAX_SERIAL causing diffs to not load
http://code.google.com/p/reviewboard/issues/detail?id=845

It didn't work:

easy_install --upgrade Djblets
Searching for Djblets
Reading http://pypi.python.org/simple/Djblets/
Reading http://www.review-board.org/wiki/Djblets
Reading http://www.review-board.org/downloads/nightlies
Best match: djblets 0.5alpha2.dev-20090203
Processing djblets-0.5alpha2.dev_20090203-py2.5.egg
djblets 0.5alpha2.dev-20090203 is already the active version in  
easy-install.pth

Using  
c:\devtools\python25\lib\site-packages\djblets-0.5alpha2.dev_20090203-py2.5.egg
Reading http://downloads.review-board.org/mirror/
Reading http://downloads.review-board.org/nightlies/
Processing dependencies for Djblets
Finished processing dependencies for Djblets

--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings

--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en
-~--~~~~--~~--~--~---



Issue 845 in reviewboard: AJAX_SERIAL causing diffs to not load

2009-02-03 Thread codesite-noreply


Comment #5 on issue 845 by keithhoffman22: AJAX_SERIAL causing diffs to not  
load
http://code.google.com/p/reviewboard/issues/detail?id=845

I'm seeing a similar error.  I'm installing reviewboard for the first time  
and am
presumably up to date.  I get a TypeError instead when attempting to view  
diffs, also
occurring at line 53 in views.py.

It looks like maybe it just need a str(settings.AJAX_SPECIAL) but I'm a  
relative
novice to python and don't know how to recompile (right word?) the egg.   
Just
changing the code didn't work.

Traceback (most recent call last):
   File
/usr/lib/python2.5/site-packages/ReviewBoard-1.0alpha2.dev_20090203-py2.5.egg/reviewboard/diffviewer/views.py,
line 193, in view_diff_fragment
 chunkindex,
   File
/usr/lib/python2.5/site-packages/ReviewBoard-1.0alpha2.dev_20090203-py2.5.egg/reviewboard/diffviewer/views.py,
line 53, in build_diff_fragment
  key += '-' + str(settings.AJAX_SERIAL) 
TypeError: cannot concatenate 'str' and 'int' objects




--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings

--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en
-~--~~~~--~~--~--~---



Issue 845 in reviewboard: AJAX_SERIAL causing diffs to not load

2009-02-03 Thread codesite-noreply


Comment #6 on issue 845 by keithhoffman22: AJAX_SERIAL causing diffs to not  
load
http://code.google.com/p/reviewboard/issues/detail?id=845

Ok, if you change line 53 to read
key += '-' + str(settings.AJAX_SERIAL)

and then do a (at least on Ubuntu server)
/etc/init.d/apache2 restart

things SEEM to work.

--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings

--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en
-~--~~~~--~~--~--~---



Issue 845 in reviewboard: AJAX_SERIAL causing diffs to not load

2009-02-03 Thread codesite-noreply


Comment #8 on issue 845 by keithhoffman22: AJAX_SERIAL causing diffs to not  
load
http://code.google.com/p/reviewboard/issues/detail?id=845

Oops, the diff will only work the first time.  After that, you'll get the  
error
mentioned by the OP:

'Settings' object has no attribute 'AJAX_SERIAL' Details

--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings

--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en
-~--~~~~--~~--~--~---



Issue 845 in reviewboard: AJAX_SERIAL causing diffs to not load

2009-02-03 Thread codesite-noreply


Comment #4 on issue 845 by chipx86: AJAX_SERIAL causing diffs to not load
http://code.google.com/p/reviewboard/issues/detail?id=845

Weird.. Okay, I have to check.. You restarted the server, right?

--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings

--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en
-~--~~~~--~~--~--~---



Issue 845 in reviewboard: AJAX_SERIAL causing diffs to not load

2009-02-03 Thread codesite-noreply

Updates:
Status: Started

Comment #9 on issue 845 by chipx86: AJAX_SERIAL causing diffs to not load
http://code.google.com/p/reviewboard/issues/detail?id=845

Okay, I have an idea as to the problem. I'll look into it and get a fix  
into SVN.

--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings

--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en
-~--~~~~--~~--~--~---



Issue 845 in reviewboard: AJAX_SERIAL causing diffs to not load

2009-02-03 Thread codesite-noreply

Updates:
Status: Fixed

Comment #10 on issue 845 by chipx86: AJAX_SERIAL causing diffs to not load
http://code.google.com/p/reviewboard/issues/detail?id=845

Fixed in Djblets and Review Board SVN.

I'll be doing a 1.0 alpha 2 release soon.

--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings

--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en
-~--~~~~--~~--~--~---



Issue 845 in reviewboard: AJAX_SERIAL causing diffs to not load

2009-02-03 Thread codesite-noreply


Comment #2 on issue 845 by chipx86: AJAX_SERIAL causing diffs to not load
http://code.google.com/p/reviewboard/issues/detail?id=845

Issue 846 has been merged into this issue.

--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings

--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en
-~--~~~~--~~--~--~---



Issue 845 in reviewboard: AJAX_SERIAL causing diffs to not load

2009-02-03 Thread codesite-noreply

Updates:
Status: NeedInfo

Comment #1 on issue 845 by chipx86: AJAX_SERIAL causing diffs to not load
http://code.google.com/p/reviewboard/issues/detail?id=845

Make sure you upgrade Djblets as well.

We're putting out a release tonight and will fix dependencies so the  
required Djblets
is auto-fetched.

--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings

--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en
-~--~~~~--~~--~--~---



Issue 845 in reviewboard: AJAX_SERIAL causing diffs to not load

2009-02-03 Thread codesite-noreply

Status: New
Owner: 
Labels: Type-Defect Priority-Medium

New issue 845 by jefflamb: AJAX_SERIAL causing diffs to not load
http://code.google.com/p/reviewboard/issues/detail?id=845

We upgraded from r1668 to r1739 today.  When looking at diffs, we get this:
Error: 'Settings' object has no attribute 'AJAX_SERIAL'

Removing the change in r1736 allows us to see the diffs again.  However,
the progressive loading spinner shows constantly next to some (not all)
lines in the Files changed list at the top of a diff page.

--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings

--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en
-~--~~~~--~~--~--~---