Comment #21 on issue 929 by trowb...@gmail.com: reviewboard should not
alter the diff file
http://code.google.com/p/reviewboard/issues/detail?id=929
Issue 2953 has been merged into this issue.
--
You received this message because this project is configured to send all
issue notifications
Updates:
Status: PendingReview
Owner: chip...@gmail.com
Labels: -Priority-Medium Priority-Critical Milestone-Release1.6.x
Comment #18 on issue 929 by chip...@gmail.com: reviewboard should not alter
the diff file
http://code.google.com/p/reviewboard/issues/detail?id=929
Updates:
Status: Fixed
Comment #19 on issue 929 by chip...@gmail.com: reviewboard should not alter
the diff file
http://code.google.com/p/reviewboard/issues/detail?id=929
This should be fixed properly now, and a release is going up tonight.
--
You received this message because you
Comment #20 on issue 929 by chip...@gmail.com: reviewboard should not alter
the diff file
http://code.google.com/p/reviewboard/issues/detail?id=929
Pushed to release-1.6.x (8281c37c4fae1f5a283c735f1c7e7cf8546767ac)
--
You received this message because you are subscribed to the Google Groups
Updates:
Status: New
Comment #17 on issue 929 by trowb...@gmail.com: reviewboard should not
alter the diff file
http://code.google.com/p/reviewboard/issues/detail?id=929
(No comment was entered for this change.)
--
You received this message because you are subscribed to the Google
Comment #15 on issue 929 by trowb...@gmail.com: reviewboard should not
alter the diff file
http://code.google.com/p/reviewboard/issues/detail?id=929
Issue 2690 has been merged into this issue.
--
You received this message because you are subscribed to the Google Groups
reviewboard-issues
Comment #16 on issue 929 by srivatsa...@gmail.com: reviewboard should not
alter the diff file
http://code.google.com/p/reviewboard/issues/detail?id=929
It is not clear whether this issue has been closed or not. Comment #11
gives me the impression this has been fixed? Could you please let
Comment #12 on issue 929 by d...@vidsolbach.de: reviewboard should not
alter the diff file
http://code.google.com/p/reviewboard/issues/detail?id=929
Hi Chris,
can you elaborate on how you changed diff handling for git? We have a user
of reviewboard.kde.org who saw that all information
Comment #13 on issue 929 by d...@vidsolbach.de: reviewboard should not
alter the diff file
http://code.google.com/p/reviewboard/issues/detail?id=929
Ups sorry, attached the stripped down version. Here is the original patch
with the additional info at the top.
Attachments:
Comment #10 on issue 929 by sed...@gmail.com: reviewboard should not alter
the diff file
http://code.google.com/p/reviewboard/issues/detail?id=929
All git diff format support tickets were closed as duplicate of this
ticket. I don't know why but the need for git diff format support has more
Updates:
Status: NeedInfo
Comment #11 on issue 929 by chip...@gmail.com: reviewboard should not alter
the diff file
http://code.google.com/p/reviewboard/issues/detail?id=929
Hi sedatk,
The reason they were closed is that they're all symptoms of Review Board
inadvertently stripping
Comment #8 on issue 929 by tif...@gmail.com: reviewboard should not alter
the diff file
http://code.google.com/p/reviewboard/issues/detail?id=929
This really seems like a big issue. It causes git diff files containing
diffs concerning binary or utf16 files to become corrupted. This makes
Comment #7 on issue 929 by trowb...@gmail.com: reviewboard should not alter
the diff file
http://code.google.com/p/reviewboard/issues/detail?id=929
Issue 2420 has been merged into this issue.
--
You received this message because you are subscribed to the Google Groups
reviewboard-issues
Comment #6 on issue 929 by trowb...@gmail.com: reviewboard should not alter
the diff file
http://code.google.com/p/reviewboard/issues/detail?id=929
Issue 2172 has been merged into this issue.
--
You received this message because you are subscribed to the Google Groups
reviewboard-issues
Comment #4 on issue 929 by chipx86: reviewboard should not alter the diff
file
http://code.google.com/p/reviewboard/issues/detail?id=929
It does do this. It just breaks it up per-file (which is needed). The
problem is that the parser doesn't know about some of the extra metadata.
So
Comment #5 on issue 929 by d...@n-cube.org: reviewboard should not alter
the diff file
http://code.google.com/p/reviewboard/issues/detail?id=929
I wonder if this wouldn't still be a good idea. I was trying to review
http://reviews.reviewboard.org/r/1737/ the other day because I thought it
16 matches
Mail list logo
