Re: Issue 1235 in reviewboard: More intelligent handling of rename operations.
Updates: Status: Fixed Comment #13 on issue 1235 by trowb...@gmail.com: More intelligent handling of rename operations. http://code.google.com/p/reviewboard/issues/detail?id=1235 This is generally fixed for most SCMs when using rbtools to generate the diff. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/groups/opt_out.
Re: Issue 1235 in reviewboard: More intelligent handling of rename operations.
Comment #12 on issue 1235 by gi...@ypc.cz: More intelligent handling of rename operations. http://code.google.com/p/reviewboard/issues/detail?id=1235 I try to generate "git diff -M --full-index revA revB" but the patch is not accepted by RB with error: The file 'path/to/fileB' (r) could not be found in the repository Where could be the problem? I'll try to add # Node ID/ # Parent at the top of diff file but no success (same result), if I try to prepend before line Similarity index 100% a line index revA..revB 100644 the error is only more concrete: The file 'path/to/fileB' (revA) could not be found in the repository I suppose that fileB should be searched in revB not revA. Thank for any advice (We use RB v1.6.4.1). -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1235 in reviewboard: More intelligent handling of rename operations.
Comment #11 on issue 1235 by carl.van...@gmail.com: More intelligent handling of rename operations. http://code.google.com/p/reviewboard/issues/detail?id=1235 Here's a sample mecurial extension that generates the required diff format for reviewboard including renames. It's a quick hack which needs cleanup. Also supports generating 'parent diff' if a review is based on a yet to be merged previous review. Attachments: gdiff.py 3.4 KB -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1235 in reviewboard: More intelligent handling of rename operations.
Comment #10 on issue 1235 by carl.van...@gmail.com: More intelligent handling of rename operations. http://code.google.com/p/reviewboard/issues/detail?id=1235 It seems this issue is actually fixed in at least 1.6 RC2. uploading a patch as: 'git diff --full-index -M' works fine. The outstanding issue is handling renames without modify, add and delete of empty files. I've comments put in Issue 2184. -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1235 in reviewboard: More intelligent handling of rename operations.
Comment #9 on issue 1235 by carl.van...@gmail.com: More intelligent handling of rename operations. http://code.google.com/p/reviewboard/issues/detail?id=1235 Ok, so I rediscovered that adding the #NoteID / #Parent Id to the git-diff patch allows reviewboard to get this needed info. Also found a reviewboard mercurial extension that does the same. I'll be making my own simple extension that just does the patch generation. -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1235 in reviewboard: More intelligent handling of rename operations.
Comment #8 on issue 1235 by carl.van...@gmail.com: More intelligent handling of rename operations. http://code.google.com/p/reviewboard/issues/detail?id=1235 The review I am trying has both rename and modifications so I don't think its the same issue. I see that thread mentions using 'hg export -g', which I wasn't doing. Note: the export in that thread appears to be for a single commit. We typically do reviews on a branch that is going to merge, having multiple commits. Thus I tried for example: 'hg export -g tip:50324 > merge-review.patch' Reviewboard won't even allow that resultant patch-file to be uploaded saying file of first change in the patch can't be found. -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1235 in reviewboard: More intelligent handling of rename operations.
Comment #7 on issue 1235 by shul...@gmail.com: More intelligent handling of rename operations. http://code.google.com/p/reviewboard/issues/detail?id=1235 there is still an issue with pure file rename in mercurial http://code.google.com/p/reviewboard/issues/detail?id=2184 -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1235 in reviewboard: More intelligent handling of rename operations.
Comment #6 on issue 1235 by carl.van...@gmail.com: More intelligent handling of rename operations. http://code.google.com/p/reviewboard/issues/detail?id=1235 Can you elaborate? Uploading a git-style patch generated by 'hg diff -g' causes exceptions when trying to view the diff. Uploading a standard diff doesn't get renames picked up. I'm running reviewboard "1.6 RC2" -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1235 in reviewboard: More intelligent handling of rename operations.
Comment #5 on issue 1235 by trowb...@gmail.com: More intelligent handling of rename operations. http://code.google.com/p/reviewboard/issues/detail?id=1235 We actually support showing renames with mercurial, now. -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1235 in reviewboard: More intelligent handling of rename operations.
Comment #4 on issue 1235 by carl.van...@gmail.com: More intelligent handling of rename operations. http://code.google.com/p/reviewboard/issues/detail?id=1235 Mercurial can also provide rename information in the patch when doing "hg diff -g" to give git style diffs. -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1235 in reviewboard: More intelligent handling of rename operations.
Comment #3 on issue 1235 by gm...@crypt.org: More intelligent handling of rename operations. http://code.google.com/p/reviewboard/issues/detail?id=1235 Note that for the git world a good starting point is 'git diff --full-index -M master'. As well as mentioning renames, it actually gives the diff between the before- and after-move paths. (Currently in v1.5, you can't upload such a diff into reviewboard: it sees a diff between "a/old/path" and "b/new/path", and complains that "old/path (revision )" doesn't exist in the repository.) I currently have a 600kB diff in review that reduces to 100kB with -M. It involves moving some 40 files, each with small differences as well as the move (primarily the class name). Resolving this may also link to href="http://code.google.com/p/reviewboard/issues/detail?id=1066";>issue 1066. -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1235 in reviewboard: More intelligent handling of rename operations.
Updates: Labels: Component-DiffViewer Comment #2 on issue 1235 by trowbrds: More intelligent handling of rename operations. http://code.google.com/p/reviewboard/issues/detail?id=1235 (No comment was entered for this change.) -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1235 in reviewboard: More intelligent handling of rename operations.
Comment #1 on issue 1235 by trowbrds: More intelligent handling of rename operations. http://code.google.com/p/reviewboard/issues/detail?id=1235 Issue 1089 has been merged into this issue. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
