Re: Issue 1426 in reviewboard: Reply on the diff page is confusing and error-prone.
Comment #21 on issue 1426 by trowb...@gmail.com: Reply on the diff page is confusing and error-prone. https://code.google.com/p/reviewboard/issues/detail?id=1426 Issue 3920 has been merged into this issue. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Issue 1426 in reviewboard: Reply on the diff page is confusing and error-prone.
Comment #20 on issue 1426 by trowb...@gmail.com: Reply on the diff page is confusing and error-prone. https://code.google.com/p/reviewboard/issues/detail?id=1426 Issue 3568 has been merged into this issue. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Issue 1426 in reviewboard: Reply on the diff page is confusing and error-prone.
Comment #17 on issue 1426 by eshara...@gmail.com: Reply on the diff page is confusing and error-prone. http://code.google.com/p/reviewboard/issues/detail?id=1426 I agree 1000% with comment #13. Having the reply button cause you to navigate away from the diff is the cause of the confusion; being able to add replies in place would alleviate that. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/groups/opt_out.
Re: Issue 1426 in reviewboard: Reply on the diff page is confusing and error-prone.
Comment #18 on issue 1426 by matt...@salsitasoft.com: Reply on the diff page is confusing and error-prone. http://code.google.com/p/reviewboard/issues/detail?id=1426 Also agree 1000%. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/groups/opt_out.
Re: Issue 1426 in reviewboard: Reply on the diff page is confusing and error-prone.
Comment #19 on issue 1426 by chip...@gmail.com: Reply on the diff page is confusing and error-prone. http://code.google.com/p/reviewboard/issues/detail?id=1426 Issue 3148 has been merged into this issue. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/groups/opt_out.
Re: Issue 1426 in reviewboard: Reply on the diff page is confusing and error-prone.
Comment #14 on issue 1426 by trowb...@gmail.com: Reply on the diff page is confusing and error-prone. http://code.google.com/p/reviewboard/issues/detail?id=1426 Issue 3160 has been merged into this issue. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/groups/opt_out.
Re: Issue 1426 in reviewboard: Reply on the diff page is confusing and error-prone.
Comment #15 on issue 1426 by trowb...@gmail.com: Reply on the diff page is confusing and error-prone. http://code.google.com/p/reviewboard/issues/detail?id=1426 Bug 3160 added some interesting observations about the Add Comment button: What's the URL of the page this enhancement relates to, if any? http://site/r/1/diff/ Describe the enhancement and the motivation for it. 1. Person A posts a comment/review 2. Person B clicks on the blue bubble or on the same line number 3. Person B sees the previous comment in a blue box and a green box ready for input that says Add comment. 3. Person B is confused on whether the green box is a reply or a new comment. I would expect that the title of the green box is New comment, as Add comment can be read as adding a comment/reply to the review comment seen in the blue box. What operating system are you using? What browser? Windows 7, Firefox Please provide any additional information below. This is related to issue 1426, but I feel it is a separate issue (issue 1426 is about the confusion when clicking the reply button, this about the confusion on whether you need to click the reply button or whether the nice big text box is already a reply). I plan to address this in a translation file for now (along with translating Submitted to Completed, but I can understand that that may not be universally better), but having it more clear in the actual application would be preferred. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/groups/opt_out.
Re: Issue 1426 in reviewboard: Reply on the diff page is confusing and error-prone.
Comment #16 on issue 1426 by trowb...@gmail.com: Reply on the diff page is confusing and error-prone. http://code.google.com/p/reviewboard/issues/detail?id=1426 Issue 3160 has been merged into this issue. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/groups/opt_out.
Re: Issue 1426 in reviewboard: Reply on the diff page is confusing and error-prone.
Comment #13 on issue 1426 by sumee...@gmail.com: Reply on the diff page is confusing and error-prone. http://code.google.com/p/reviewboard/issues/detail?id=1426 the fix is to probably allow entering comments from the diff page. why should a user have to navigate to a different page and lose their place in order to reply? -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/groups/opt_out.
Re: Issue 1426 in reviewboard: Reply on the diff page is confusing and error-prone.
Comment #12 on issue 1426 by kiwi...@gmail.com: Reply on the diff page is confusing and error-prone. http://code.google.com/p/reviewboard/issues/detail?id=1426 The documentation itself says : The comment box is not the place to reply to those comments. Instead, you can click the Reply link next to the particular comment, which will take you back to the review request page and open a reply box. I expected from this that when clicking the reply button a reply box would open on the new page. It doesn't (RB 1.7.6). -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
Re: Issue 1426 in reviewboard: Reply on the diff page is confusing and error-prone.
Comment #11 on issue 1426 by rewilli...@thesba.com: Reply on the diff page is confusing and error-prone. http://code.google.com/p/reviewboard/issues/detail?id=1426 I just ran into this and lost a bunch of comments in the process. A team member posted a new diff on a review, so I was reviewing it. He'd replied to one of my comments on the previous diff and closed the issue. I wasn't satisfied, so I wanted to reopen it and reply to his comment on the newest diff. While in diff view, I could see my original comment and his reply, but when I clicked the reply button in the comment dialog, I was just taken back to the main review page. No text field was opened up and pre-selected for me, and even worse, when I returned to the diff view, I'd lost all the comments I already wrote on my in-progress review update. What I would expect is that when I click reply, I get presented with a text field in which to type my reply, right in-situ. Click save, and it's done. Then it all gets submitted when I actually publish the review. I shouldn't have to leave the page to reply to a comment, and I absolutely should never lose comments already entered, especially with nary a warning. Safari 6.0.2. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
Re: Issue 1426 in reviewboard: Reply on the diff page is confusing and error-prone.
Updates: Summary: Reply on the diff page is confusing and error-prone. Comment #8 on issue 1426 by trowb...@gmail.com: Reply on the diff page is confusing and error-prone. http://code.google.com/p/reviewboard/issues/detail?id=1426 (No comment was entered for this change.) -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
Re: Issue 1426 in reviewboard: Reply on the diff page is confusing and error-prone.
Comment #9 on issue 1426 by trowb...@gmail.com: Reply on the diff page is confusing and error-prone. http://code.google.com/p/reviewboard/issues/detail?id=1426 Issue 2559 has been merged into this issue. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
Re: Issue 1426 in reviewboard: Reply on the diff page is confusing and error-prone.
Comment #10 on issue 1426 by trowb...@gmail.com: Reply on the diff page is confusing and error-prone. http://code.google.com/p/reviewboard/issues/detail?id=1426 Issue 2910 has been merged into this issue. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues?hl=en. For more options, visit https://groups.google.com/groups/opt_out.