Re: Issue 1515 in reviewboard: SVN hook can include empty arguments which seems to confuse svn diff
Updates: Status: Fixed Comment #8 on issue 1515 by trowbrds: SVN hook can include empty arguments which seems to confuse svn diff http://code.google.com/p/reviewboard/issues/detail?id=1515 (No comment was entered for this change.) -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1515 in reviewboard: SVN hook can include empty arguments which seems to confuse svn diff
Updates: Status: PendingReview Comment #7 on issue 1515 by trowbrds: SVN hook can include empty arguments which seems to confuse svn diff http://code.google.com/p/reviewboard/issues/detail?id=1515 (No comment was entered for this change.) -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1515 in reviewboard: SVN hook can include empty arguments which seems to confuse svn diff
Comment #6 on issue 1515 by stodge: SVN hook can include empty arguments which seems to confuse svn diff http://code.google.com/p/reviewboard/issues/detail?id=1515 Created review request http://reviews.reviewboard.org/r/1440/. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1515 in reviewboard: SVN hook can include empty arguments which seems to confuse svn diff
Comment #5 on issue 1515 by stodge: SVN hook can include empty arguments which seems to confuse svn diff http://code.google.com/p/reviewboard/issues/detail?id=1515 Not for the crash in comment 3. I think you explained this my other bug report. I'll try to get back to this next week. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1515 in reviewboard: SVN hook can include empty arguments which seems to confuse svn diff
Updates: Status: NeedInfo Comment #4 on issue 1515 by chipx86: SVN hook can include empty arguments which seems to confuse svn diff http://code.google.com/p/reviewboard/issues/detail?id=1515 Are you using post-review? -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1515 in reviewboard: SVN hook can include empty arguments which seems to confuse svn diff
Comment #3 on issue 1515 by stodge: SVN hook can include empty arguments
which seems to confuse svn diff
http://code.google.com/p/reviewboard/issues/detail?id=1515
Environment:
Request Method: POST
Request URL: http://reviews.reviewboard.org/r/new/
Django Version: 1.1.1
Python Version: 2.5.2
Installed Applications:
['django.contrib.admin',
'django.contrib.auth',
'django.contrib.contenttypes',
'django.contrib.markup',
'django.contrib.sites',
'django.contrib.sessions',
'djblets.datagrid',
'djblets.feedview',
'djblets.log',
'djblets.siteconfig',
'djblets.util',
'djblets.webapi',
'reviewboard.accounts',
'reviewboard.admin',
'reviewboard.changedescs',
'reviewboard.diffviewer',
'reviewboard.iphone',
'reviewboard.notifications',
'reviewboard.reports',
'reviewboard.reviews',
'reviewboard.scmtools',
'reviewboard.webapi',
'django_evolution']
Installed Middleware:
('django.middleware.gzip.GZipMiddleware',
'django.middleware.common.CommonMiddleware',
'django.middleware.doc.XViewMiddleware',
'django.middleware.http.ConditionalGetMiddleware',
'django.middleware.locale.LocaleMiddleware',
'django.contrib.sessions.middleware.SessionMiddleware',
'django.contrib.auth.middleware.AuthenticationMiddleware',
'djblets.siteconfig.middleware.SettingsMiddleware',
'reviewboard.admin.middleware.LoadSettingsMiddleware',
'djblets.log.middleware.LoggingMiddleware',
'reviewboard.admin.middleware.CheckUpdatesRequiredMiddleware',
'reviewboard.admin.middleware.X509AuthMiddleware')
Traceback:
File
"/usr/lib/python2.5/site-packages/Django-1.1.1-py2.5.egg/django/core/handlers/base.py"
in
get_response
92. response = callback(request, *callback_args,
**callback_kwargs)
File
"/usr/lib/python2.5/site-packages/Djblets-0.5.7-py2.5.egg/djblets/auth/util.py"
in _checklogin
46. return view_func(request, *args, **kwargs)
File
"/usr/lib/python2.5/site-packages/ReviewBoard-1.5beta1-py2.5.egg/reviewboard/reviews/views.py"
in new_review_request
69.
parent_diff_file=request.FILES.get('parent_diff_path'))
File
"/usr/lib/python2.5/site-packages/ReviewBoard-1.5beta1-py2.5.egg/reviewboard/reviews/forms.py"
in create
183. attach_to_history=True)
File
"/usr/lib/python2.5/site-packages/ReviewBoard-1.5beta1-py2.5.egg/reviewboard/reviews/forms.py"
in create
235. history)
File
"/usr/lib/python2.5/site-packages/ReviewBoard-1.5beta1-py2.5.egg/reviewboard/diffviewer/forms.py"
in create
66. raise EmptyDiffError(_("The diff file is empty"))
Exception Type: EmptyDiffError at /r/new/
Exception Value: The diff file is empty
--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings
--
You received this message because you are subscribed to the Google Groups
"reviewboard-issues" group.
To post to this group, send email to reviewboard-iss...@googlegroups.com.
To unsubscribe from this group, send email to
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at
http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1515 in reviewboard: SVN hook can include empty arguments which seems to confuse svn diff
Comment #2 on issue 1515 by stodge: SVN hook can include empty arguments which seems to confuse svn diff http://code.google.com/p/reviewboard/issues/detail?id=1515 I tried already but the site crashed with an exception that the patch was empty. I guess I need to diff against the git repository except git clones are blocked by our corporate firewall. :( -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1515 in reviewboard: SVN hook can include empty arguments which seems to confuse svn diff
Comment #1 on issue 1515 by chipx86: SVN hook can include empty arguments which seems to confuse svn diff http://code.google.com/p/reviewboard/issues/detail?id=1515 Can you post the patch at http://reviews.reviewboard.org/ ? We don't review patches on the bug tracker. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
