Re: Issue 1569 in reviewboard: Code review linebreaks are not preserved in all views (i.e. mail)
Comment #8 on issue 1569 by chipx86: Code review linebreaks are not preserved in all views (i.e. mail) http://code.google.com/p/reviewboard/issues/detail?id=1569 Fixed on master (5344e92) -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1569 in reviewboard: Code review linebreaks are not preserved in all views (i.e. mail)
Comment #7 on issue 1569 by vesterbaek: Code review linebreaks are not preserved in all views (i.e. mail) http://code.google.com/p/reviewboard/issues/detail?id=1569 The review description field wraps long lines in the browser => I'm used to just typing and having the text wrapped. In the sent out emails, the description is not wrapped (at least on my lotus notes web client), causing very wide emails. My html/css has gone a bit rusty, but telling the pre's to break if necessary seems to do the trick. I've added the following to email_base.html: pre {overflow-x: auto; /* Use horizontal scroller if needed; for Firefox 2, notneeded in Firefox 3 */ white-space: pre-wrap; /* css-3 */ white-space: -moz-pre-wrap !important; /* Mozilla, since 1999 */ white-space: -pre-wrap; /* Opera 4-6 */ white-space: -o-pre-wrap; /* Opera 7 */ /* width: 99%; */ word-wrap: break-word; /* Internet Explorer 5.5+ */ } The css is from here: http://www.longren.org/2006/09/27/wrapping-text-inside-pre-tags/. There might be a better way of achieving the same ... -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1569 in reviewboard: Code review linebreaks are not preserved in all views (i.e. mail)
Updates: Status: Fixed Owner: chipx86 Comment #6 on issue 1569 by chipx86: Code review linebreaks are not preserved in all views (i.e. mail) http://code.google.com/p/reviewboard/issues/detail?id=1569 Fixed on master (fc85106) -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1569 in reviewboard: Code review linebreaks are not preserved in all views (i.e. mail)
Updates: Status: PendingReview Labels: Milestone-Release1.5 Component-EMail Comment #5 on issue 1569 by chipx86: Code review linebreaks are not preserved in all views (i.e. mail) http://code.google.com/p/reviewboard/issues/detail?id=1569 There's a patch pending for this that will be in the next beta. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1569 in reviewboard: Code review linebreaks are not preserved in all views (i.e. mail)
Comment #4 on issue 1569 by o3sisqa: Code review linebreaks are not preserved in all views (i.e. mail) http://code.google.com/p/reviewboard/issues/detail?id=1569 any more information needed for this? -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1569 in reviewboard: Code review linebreaks are not preserved in all views (i.e. mail)
Comment #3 on issue 1569 by o3sisqa: Code review linebreaks are not preserved in all views (i.e. mail) http://code.google.com/p/reviewboard/issues/detail?id=1569 Heres a screenshot of a mail inside a webmailer (citadel.org) But i've seen the same in Outlook. Attachments: linebreak_missing.png 34.0 KB -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1569 in reviewboard: Code review linebreaks are not preserved in all views (i.e. mail)
Comment #2 on issue 1569 by o3sisqa: Code review linebreaks are not preserved in all views (i.e. mail) http://code.google.com/p/reviewboard/issues/detail?id=1569 tried to add a demo comment to http://demo.reviewboard.org/r/44/ I hope you're getting the mail for this one? -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1569 in reviewboard: Code review linebreaks are not preserved in all views (i.e. mail)
Updates: Status: NeedInfo Comment #1 on issue 1569 by chipx86: Code review linebreaks are not preserved in all views (i.e. mail) http://code.google.com/p/reviewboard/issues/detail?id=1569 I'm afraid I need more details. Can you show some examples or maybe screenshots of what you're expecting? -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
