Updates:
Status: WontFix
Comment #15 on issue 1668 by chip...@gmail.com: Diffs not applying cleanly
circa 1.0.7 with odd line endings
http://code.google.com/p/reviewboard/issues/detail?id=1668
I know your question is now a year old, but I missed it. Sorry :/
Basically, yes, you
Comment #5 on issue 1668 by chipx86: Diffs not applying cleanly circa 1.0.7
with odd line endings
http://code.google.com/p/reviewboard/issues/detail?id=1668
One thing I'm not sure from the repro case here. Is this the source file
(pre-patch)
that has the funky newlines? Or does the patch
Updates:
Owner: chipx86
Labels: -Priority-Medium Priority-Critical Milestone-Release1.0.x
Component-DiffViewer
Comment #6 on issue 1668 by chipx86: Diffs not applying cleanly circa 1.0.7
with odd line endings
http://code.google.com/p/reviewboard/issues/detail?id=1668
(No comment
Updates:
Status: Confirmed
Comment #7 on issue 1668 by chipx86: Diffs not applying cleanly circa 1.0.7
with odd line endings
http://code.google.com/p/reviewboard/issues/detail?id=1668
Nevermind, I have a test case now. I just don't have a fix that's working.
The problem is that we
Comment #8 on issue 1668 by chipx86: Diffs not applying cleanly circa 1.0.7
with odd line endings
http://code.google.com/p/reviewboard/issues/detail?id=1668
Of course, if we then change the diff so that the ^M is preserved, it'll
break
against the source input where the ^M is not
Comment #9 on issue 1668 by AaronJSherman: Diffs not applying cleanly circa
1.0.7 with odd line endings
http://code.google.com/p/reviewboard/issues/detail?id=1668
There's, of course, no question that this is outside of what one would
typically
expect, but as for how these files are getting
Comment #11 on issue 1668 by chipx86: Diffs not applying cleanly circa
1.0.7 with odd line endings
http://code.google.com/p/reviewboard/issues/detail?id=1668
Let me ask.. Is the intent of the ^M in these files to be newlines, or are
they just
ending up this way from broken editors? Are
Comment #3 on issue 1668 by AaronJSherman: Diffs not applying cleanly circa
1.0.7 with odd line endings
http://code.google.com/p/reviewboard/issues/detail?id=1668
Ah, OK, here's the easiest way to reproduce. This worked on a file we had
checked in:
Open an *existing* file (my post above
Comment #2 on issue 1668 by AaronJSherman: Diffs not applying cleanly circa
1.0.7 with odd line endings
http://code.google.com/p/reviewboard/issues/detail?id=1668
I'll see what I can do tonight. I didn't have anything clean that I could
hand off
outside of the company when I filed this,
