Re: Issue 1794 in reviewboard: alert (popup) the user when attempting to leave a page with unpublished changes
Comment #10 on issue 1794 by dlalibe...@google.com: alert (popup) the user when attempting to leave a page with unpublished changes http://code.google.com/p/reviewboard/issues/detail?id=1794 Glad to hear it. Thanks for the clarification. -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1794 in reviewboard: alert (popup) the user when attempting to leave a page with unpublished changes
Comment #9 on issue 1794 by trowb...@gmail.com: alert (popup) the user when attempting to leave a page with unpublished changes http://code.google.com/p/reviewboard/issues/detail?id=1794 I think there was some confusion all around. Both issues are now fixed. For upublished changes, we don't warn, but the draft banners are much more apparent. For unsaved changes, we'll warn before navigating away from the page. -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1794 in reviewboard: alert (popup) the user when attempting to leave a page with unpublished changes
Comment #8 on issue 1794 by dlalibe...@google.com: alert (popup) the user when attempting to leave a page with unpublished changes http://code.google.com/p/reviewboard/issues/detail?id=1794 In case my comment on issue 2150 gets otherwise ignored (http://code.google.com/p/reviewboard/issues/detail?id=2150#c2), while it is nice that the issue of leaving a page with unpublished changes is resolved, issue 2150 is about unSaved changes, not unpublished changes. As such, comment 4 here, which is about merging in issue 2150, should not have been done. It appears that issue 1706 and issue 2067 are also about losing unsaved changes in the same way. -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1794 in reviewboard: alert (popup) the user when attempting to leave a page with unpublished changes
Updates: Status: Fixed Comment #7 on issue 1794 by chip...@gmail.com: alert (popup) the user when attempting to leave a page with unpublished changes http://code.google.com/p/reviewboard/issues/detail?id=1794 (No comment was entered for this change.) -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1794 in reviewboard: alert (popup) the user when attempting to leave a page with unpublished changes
Updates: Status: PendingReview Comment #6 on issue 1794 by chip...@gmail.com: alert (popup) the user when attempting to leave a page with unpublished changes http://code.google.com/p/reviewboard/issues/detail?id=1794 (No comment was entered for this change.) -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1794 in reviewboard: alert (popup) the user when attempting to leave a page with unpublished changes
Updates: Status: Confirmed Owner: chip...@gmail.com Labels: -Priority-Medium Priority-Critical Milestone-Release1.6 Comment #5 on issue 1794 by chip...@gmail.com: alert (popup) the user when attempting to leave a page with unpublished changes http://code.google.com/p/reviewboard/issues/detail?id=1794 (No comment was entered for this change.) -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1794 in reviewboard: alert (popup) the user when attempting to leave a page with unpublished changes
Comment #4 on issue 1794 by chip...@gmail.com: alert (popup) the user when attempting to leave a page with unpublished changes http://code.google.com/p/reviewboard/issues/detail?id=1794 Issue 2150 has been merged into this issue. -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1794 in reviewboard: alert (popup) the user when attempting to leave a page with unpublished changes
Comment #3 on issue 1794 by trowb...@gmail.com: alert (popup) the user when attempting to leave a page with unpublished changes http://code.google.com/p/reviewboard/issues/detail?id=1794 Issue 2067 has been merged into this issue. -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1794 in reviewboard: alert (popup) the user when attempting to leave a page with unpublished changes
Comment #2 on issue 1794 by trowb...@gmail.com: alert (popup) the user when attempting to leave a page with unpublished changes http://code.google.com/p/reviewboard/issues/detail?id=1794 Issue 1706 has been merged into this issue. -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1794 in reviewboard: alert (popup) the user when attempting to leave a page with unpublished changes
Updates: Labels: Component-Reviews Comment #1 on issue 1794 by trowbrds: alert (popup) the user when attempting to leave a page with unpublished changes http://code.google.com/p/reviewboard/issues/detail?id=1794 (No comment was entered for this change.) -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
