Re: Issue 1795 in reviewboard: using "--submit-as" with post-review causes generated mails to be from original submitter
Updates: Status: Fixed Comment #7 on issue 1795 by trowb...@gmail.com: using "--submit-as" with post-review causes generated mails to be from original submitter http://code.google.com/p/reviewboard/issues/detail?id=1795 Fixed in release-1.7.x (8cc0f4d). -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/groups/opt_out.
Re: Issue 1795 in reviewboard: using "--submit-as" with post-review causes generated mails to be from original submitter
Updates: Status: Started Owner: trowb...@gmail.com Comment #6 on issue 1795 by trowb...@gmail.com: using "--submit-as" with post-review causes generated mails to be from original submitter http://code.google.com/p/reviewboard/issues/detail?id=1795 (No comment was entered for this change.) -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/groups/opt_out.
Re: Issue 1795 in reviewboard: using "--submit-as" with post-review causes generated mails to be from original submitter
Comment #5 on issue 1795 by wa...@meetup.com: using "--submit-as" with post-review causes generated mails to be from original submitter http://code.google.com/p/reviewboard/issues/detail?id=1795 Just upgraded to 1.7.7.1 from 1.6.2 and we are seeing this issue -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
Re: Issue 1795 in reviewboard: using "--submit-as" with post-review causes generated mails to be from original submitter
Updates: Labels: -Type-Defect Type-Enhancement Component-EMail Comment #4 on issue 1795 by chip...@gmail.com: using "--submit-as" with post-review causes generated mails to be from original submitter http://code.google.com/p/reviewboard/issues/detail?id=1795 It's part RBTools, part Review Board. But not really a bug, per se. --submit-as is used for the creation of a review request, to put it in someone else's name. That's a separate operation from publishing. When publishing, the e-mail will go out as the user logged in. There's definitely a use case for making a publish operations happen on behalf of another user, but we aren't set up for that today. So this would need to be added. One option is to just use the review request submitter for the e-mail, but that's likely not what we want in all cases. I'm hoping to introduce a multi-user workflow for review requests, where the ownership can be reassigned, and other users could modify fields with state being preserved to indicate who made the change. That won't solve your problem directly, though. You'd still need to either log in as the user, or would need to specifically do a --submit-as on that operation (which we'd have to support). -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1795 in reviewboard: using "--submit-as" with post-review causes generated mails to be from original submitter
Comment #3 on issue 1795 by michakel...@gmail.com: using "--submit-as" with post-review causes generated mails to be from original submitter http://code.google.com/p/reviewboard/issues/detail?id=1795 Is this a post-review issue? We run RB 1.5 beta 2, and see the same behavior. But the submitter in the review request is indeed the specified user (with correctly resolved e-mail address). But even later reviews to this request will never copy that submitter. Is it possible, that there is a general issue with the submitter of a review request being left out from notifications? -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1795 in reviewboard: using "--submit-as" with post-review causes generated mails to be from original submitter
Comment #2 on issue 1795 by christia...@iathh.de: using "--submit-as" with post-review causes generated mails to be from original submitter http://code.google.com/p/reviewboard/issues/detail?id=1795 I can confirm that. I see the same problem here. RBTools 0.3.2 -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1795 in reviewboard: using "--submit-as" with post-review causes generated mails to be from original submitter
Updates: Labels: Component-RBTools Comment #1 on issue 1795 by trowbrds: using "--submit-as" with post-review causes generated mails to be from original submitter http://code.google.com/p/reviewboard/issues/detail?id=1795 (No comment was entered for this change.) -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
