Re: Issue 1813 in reviewboard: allow post-review to cause notification-emails to be sent without creating explicit diff in RB

2010-09-30 Thread reviewboard


Comment #2 on issue 1813 by edgi...@gmail.com: allow post-review to cause  
notification-emails to be sent without creating explicit diff in RB

http://code.google.com/p/reviewboard/issues/detail?id=1813

I think I didn't communicate the idea clearly:  I don't expect for  
post-review to actually send the mails -- I expect the reviewboard server  
to send the mails, just as it already does.  The only difference is that  
post-review doesn't actually post a diff for review, but just tells the RB  
server "let everyone in group G know that revision X was committed".



--
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To post to this group, send email to reviewboard-iss...@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.



Re: Issue 1813 in reviewboard: allow post-review to cause notification-emails to be sent without creating explicit diff in RB

2010-09-30 Thread reviewboard

Updates:
Status: WontFix

Comment #1 on issue 1813 by trowbrds: allow post-review to cause  
notification-emails to be sent without creating explicit diff in RB

http://code.google.com/p/reviewboard/issues/detail?id=1813

There are lots of other tools out there for email notifications as a commit  
hook. post-review itself doesn't actually send out the email, and I think  
it would be inappropriate to add that functionality.


--
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To post to this group, send email to reviewboard-iss...@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.