Re: Issue 1937 in reviewboard: Intellij patch cannot be uploaded into reviewboard

2011-02-19 Thread reviewboard 

Updates:
Status: Fixed
Owner: chipx86

Comment #2 on issue 1937 by chip...@gmail.com: Intellij patch cannot be  
uploaded into reviewboard

http://code.google.com/p/reviewboard/issues/detail?id=1937

Fixed on release-1.5.x and master. This will be in 1.5.4.

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.

Re: Issue 1937 in reviewboard: Intellij patch cannot be uploaded into reviewboard

2011-01-10 Thread reviewboard 

Updates:
Status: NeedInfo
Labels: Milestone-Release1.5.x Component-DiffParser Component-SCMTools

Comment #1 on issue 1937 by chipx86: Intellij patch cannot be uploaded into  
reviewboard

http://code.google.com/p/reviewboard/issues/detail?id=1937

It'd be better to do something like:

if revision_str in ((working copy), (revision )):

and then document each version in a comment preceding it.

Probably, though, IntelliJ should be patched to be compliant, as they're  
generating an incorrect diff.


If you have time to make a patch with a unit test for RB, we'll get it into  
the next point release.


--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-iss...@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.