Re: Issue 2002 in reviewboard: linkified URL has succeeding parenthesis included in link's target URL

2012-09-29 Thread reviewboard


Comment #11 on issue 2002 by john.sin...@gmail.com: linkified URL has  
succeeding parenthesis included in link's target URL

http://code.google.com/p/reviewboard/issues/detail?id=2002

Ship it was given on the reviewboard.

--
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.



Re: Issue 2002 in reviewboard: linkified URL has succeeding parenthesis included in link's target URL

2012-09-29 Thread reviewboard

Updates:
Status: Fixed

Comment #10 on issue 2002 by trowb...@gmail.com: linkified URL has  
succeeding parenthesis included in link's target URL

http://code.google.com/p/reviewboard/issues/detail?id=2002

Fixed in master (28878fc). Thanks!

--
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.



Re: Issue 2002 in reviewboard: linkified URL has succeeding parenthesis included in link's target URL

2012-09-29 Thread reviewboard


Comment #9 on issue 2002 by john.sin...@gmail.com: linkified URL has  
succeeding parenthesis included in link's target URL

http://code.google.com/p/reviewboard/issues/detail?id=2002

http://reviews.reviewboard.org/r/3374/
Ship it! Fixed, though not "perfect" solution, should cover most cases.

--
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.



Re: Issue 2002 in reviewboard: linkified URL has succeeding parenthesis included in link's target URL

2012-09-28 Thread reviewboard


Comment #8 on issue 2002 by john.sin...@gmail.com: linkified URL has  
succeeding parenthesis included in link's target URL

http://code.google.com/p/reviewboard/issues/detail?id=2002

Having a look at this, with regards to the sbress's comment.

--
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.



Re: Issue 2002 in reviewboard: linkified URL has succeeding parenthesis included in link's target URL

2011-07-29 Thread reviewboard

Updates:
Labels: -Milestone-Release1.6 Milestone-Release1.6.x

Comment #7 on issue 2002 by chip...@gmail.com: linkified URL has succeeding  
parenthesis included in link's target URL

http://code.google.com/p/reviewboard/issues/detail?id=2002

(No comment was entered for this change.)

--
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.



Re: Issue 2002 in reviewboard: linkified URL has succeeding parenthesis included in link's target URL

2011-06-29 Thread reviewboard

Updates:
Status: Confirmed

Comment #6 on issue 2002 by chip...@gmail.com: linkified URL has succeeding  
parenthesis included in link's target URL

http://code.google.com/p/reviewboard/issues/detail?id=2002

That's a good point, and should be easy to take care of.

--
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.



Re: Issue 2002 in reviewboard: linkified URL has succeeding parenthesis included in link's target URL

2011-06-29 Thread reviewboard


Comment #5 on issue 2002 by sbress...@gmail.com: linkified URL has  
succeeding parenthesis included in link's target URL

http://code.google.com/p/reviewboard/issues/detail?id=2002

Thanks for fixing!

You might actually want to only exclude the final parenthesis if there's no  
previously unclosed open parenthesis, particularly if it immediately  
precedes the close parenthesis. That way, at least links like the follow  
would still work:


http://download.oracle.com/javase/1.4.2/docs/api/java/lang/Object.html#clone()
http://download.oracle.com/javase/1.4.2/docs/api/java/lang/Object.html#equals(java.lang.Object)

--
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.



Re: Issue 2002 in reviewboard: linkified URL has succeeding parenthesis included in link's target URL

2011-06-29 Thread reviewboard

Updates:
Status: Fixed
Owner: chip...@gmail.com

Comment #4 on issue 2002 by chip...@gmail.com: linkified URL has succeeding  
parenthesis included in link's target URL

http://code.google.com/p/reviewboard/issues/detail?id=2002

Fixed on master (2684c32)

--
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.



Re: Issue 2002 in reviewboard: linkified URL has succeeding parenthesis included in link's target URL

2011-06-17 Thread reviewboard

Updates:
Labels: EasyFix

Comment #3 on issue 2002 by chip...@gmail.com: linkified URL has succeeding  
parenthesis included in link's target URL

http://code.google.com/p/reviewboard/issues/detail?id=2002

(No comment was entered for this change.)

--
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.



Re: Issue 2002 in reviewboard: linkified URL has succeeding parenthesis included in link's target URL

2011-06-17 Thread reviewboard

Updates:
Status: Confirmed
	Labels: -Priority-Medium Priority-Low Milestone-Release1.6  
Component-Reviews


Comment #2 on issue 2002 by chip...@gmail.com: linkified URL has succeeding  
parenthesis included in link's target URL

http://code.google.com/p/reviewboard/issues/detail?id=2002

(No comment was entered for this change.)

--
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.



Re: Issue 2002 in reviewboard: linkified URL has succeeding parenthesis included in link's target URL

2011-03-20 Thread reviewboard


Comment #1 on issue 2002 by trowb...@gmail.com: linkified URL has  
succeeding parenthesis included in link's target URL

http://code.google.com/p/reviewboard/issues/detail?id=2002

Issue 2038 has been merged into this issue.

--
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.