Re: Issue 2155 in reviewboard: post-review fails to upload diff if non-ascii characters are used in diff

2011-09-24 Thread reviewboard
Comment #7 on issue 2155 by jerb...@gmail.com: post-review fails to upload diff if non-ascii characters are used in diff http://code.google.com/p/reviewboard/issues/detail?id=2155 Thanks! -- You received this message because you are subscribed to the Google Groups reviewboard-issues group.

Re: Issue 2155 in reviewboard: post-review fails to upload diff if non-ascii characters are used in diff

2011-09-23 Thread reviewboard
Comment #5 on issue 2155 by chip...@gmail.com: post-review fails to upload diff if non-ascii characters are used in diff http://code.google.com/p/reviewboard/issues/detail?id=2155 Issue 2300 has been merged into this issue. -- You received this message because you are subscribed to the

Re: Issue 2155 in reviewboard: post-review fails to upload diff if non-ascii characters are used in diff

2011-09-23 Thread reviewboard
Updates: Status: Fixed Owner: chip...@gmail.com Labels: Milestone-RBTools-Release1.0 Component-RBTools Comment #6 on issue 2155 by chip...@gmail.com: post-review fails to upload diff if non-ascii characters are used in diff

Re: Issue 2155 in reviewboard: post-review fails to upload diff if non-ascii characters are used in diff

2011-08-31 Thread reviewboard
Comment #4 on issue 2155 by jerb...@gmail.com: post-review fails to upload diff if non-ascii characters are used in diff http://code.google.com/p/reviewboard/issues/detail?id=2155 Proposed fix in a review request here: http://reviews.reviewboard.org/r/2568/ -- You received this message

Re: Issue 2155 in reviewboard: post-review fails to upload diff if non-ascii characters are used in diff

2011-08-30 Thread reviewboard
Comment #3 on issue 2155 by truan.h...@kssretail.com: post-review fails to upload diff if non-ascii characters are used in diff http://code.google.com/p/reviewboard/issues/detail?id=2155 Seeing this with RBTools 0.3.3 / latest 'nightly' file and Python 2.7 After reading this issue 11898 on

Re: Issue 2155 in reviewboard: post-review fails to upload diff if non-ascii characters are used in diff

2011-07-21 Thread reviewboard
Comment #2 on issue 2155 by tim.na...@googlemail.com: post-review fails to upload diff if non-ascii characters are used in diff http://code.google.com/p/reviewboard/issues/detail?id=2155 This appears to be caused by a change to the http lib in Python 2.7. There is some discussion on it in

Re: Issue 2155 in reviewboard: post-review fails to upload diff if non-ascii characters are used in diff

2011-06-28 Thread reviewboard
Comment #1 on issue 2155 by jerb...@gmail.com: post-review fails to upload diff if non-ascii characters are used in diff http://code.google.com/p/reviewboard/issues/detail?id=2155 BTW. I'm using --diff-filename. Here is the script we use (which in turn uses post-review):