Re: Issue 2252 in reviewboard: changes between r2 and 2 doesn't make sense
Comment #4 on issue 2252 by e.ta...@gmail.com: changes between r2 and 2 doesn't make sense http://code.google.com/p/reviewboard/issues/detail?id=2252 I'd like to see changes between trunk and latest revision too. In this way it would be possible to aggregate commits for a task in the same review, and the reviewer would be able to see the diff for the whole task. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 2252 in reviewboard: changes between r2 and 2 doesn't make sense
Comment #5 on issue 2252 by o...@humblebundle.com: changes between r2 and 2 doesn't make sense http://code.google.com/p/reviewboard/issues/detail?id=2252 FWIW, the way it works currently as I understand it: Jump to revision x shows you diffs between revision x and trunk Changes between revision x and y shows you diffs between revision x and y It's not very intuitive, but it does let you see diffs between any two revisions including trunk. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 2252 in reviewboard: changes between r2 and 2 doesn't make sense
Comment #6 on issue 2252 by chip...@gmail.com: changes between r2 and 2 doesn't make sense http://code.google.com/p/reviewboard/issues/detail?id=2252 Not trunk, just the base revision listed in the diff (which may be different in any particular diff revision). -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 2252 in reviewboard: changes between r2 and 2 doesn't make sense
Comment #7 on issue 2252 by e.ta...@gmail.com: changes between r2 and 2 doesn't make sense http://code.google.com/p/reviewboard/issues/detail?id=2252 True. Something like changes between r0 and r2. But we don't have r0. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 2252 in reviewboard: changes between r2 and 2 doesn't make sense
Updates: Status: Confirmed Owner: --- Labels: Component-DiffViewer Comment #3 on issue 2252 by trowb...@gmail.com: changes between r2 and 2 doesn't make sense http://code.google.com/p/reviewboard/issues/detail?id=2252 (No comment was entered for this change.) -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 2252 in reviewboard: changes between r2 and 2 doesn't make sense
Comment #2 on issue 2252 by o...@humblebundle.com: changes between r2 and 2 doesn't make sense http://code.google.com/p/reviewboard/issues/detail?id=2252 Nope, the r2 is not clickable... sorry I wasn't clear in my description. Glad to hear the UI will be revised at some point. I understand how it works now, but it always throws me for a loop. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 2252 in reviewboard: changes between r2 and 2 doesn't make sense
Updates: Status: NeedInfo Owner: chip...@gmail.com Comment #1 on issue 2252 by chip...@gmail.com: changes between r2 and 2 doesn't make sense http://code.google.com/p/reviewboard/issues/detail?id=2252 These are revisions of diffs on a review request, rather than revisions within the repository. This selector allows reviewers to see what changed between versions of a diff that you've uploaded. For example, if you put up a large change, then make some additional changes to it based on reviews, and update your diff, reviewers will be able to see just those changes you've made instead of having to re-read a large diff. The UI for the diff revisions selector will undergo a rewrite at some point, as its interaction is not great and is a hold-over from the very early days of Review Board. If you're on r2, you shouldn't actually be able to click r2. The style on it should indicate that it's selected as one end of the revision range. Is that not happening? Is it actually clickable? Does that clear things up? (Love the Humble Indie Bundle, btw.) -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
