Re: Issue 2259 in reviewboard: Replying to a comment on a review breaks the js popup on IE8
Updates: Status: Fixed Comment #6 on issue 2259 by trowb...@gmail.com: Replying to a comment on a review breaks the js popup on IE8 http://code.google.com/p/reviewboard/issues/detail?id=2259 I've committed this workaround to release-1.6.x (3d7e7a5) -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 2259 in reviewboard: Replying to a comment on a review breaks the js popup on IE8
Comment #5 on issue 2259 by joel.squ...@gmail.com: Replying to a comment on a review breaks the js popup on IE8 http://code.google.com/p/reviewboard/issues/detail?id=2259 My users report that this fixes the IE issue for them, which occurs in the 1.6.1 as well. -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 2259 in reviewboard: Replying to a comment on a review breaks the js popup on IE8
Comment #4 on issue 2259 by yos...@hotmail.com: Replying to a comment on a
review breaks the js popup on IE8
http://code.google.com/p/reviewboard/issues/detail?id=2259
Here's a workaround, to change the floating review box into a fixed box on
IE.
--- ./reviewboard/htdocs/media/rb/js/reviews.js.orig2011-10-14
14:57:17.0 -0400
+++ ./reviewboard/htdocs/media/rb/js/reviews.js 2011-10-14
15:05:48.0 -0400
@@ -832,6 +832,11 @@
return;
}
+/* floating fails on IE */
+if ($.browser.msie) {
+return;
+}
+
if (floatSpacer == null) {
floatSpacer = self.wrap($("")).parent();
updateSize();
--
You received this message because you are subscribed to the Google Groups
"reviewboard-issues" group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at
http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 2259 in reviewboard: Replying to a comment on a review breaks the js popup on IE8
Comment #3 on issue 2259 by atiannic...@gmail.com: Replying to a comment on a review breaks the js popup on IE8 http://code.google.com/p/reviewboard/issues/detail?id=2259 I can readily reproduce this issue so if you need more information please let me know what I can get for you. -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 2259 in reviewboard: Replying to a comment on a review breaks the js popup on IE8
Updates: Status: Confirmed Labels: -Priority-Medium Priority-Critical Milestone-Release1.6.x Browser OpSys-Windows Component-Reviews Comment #2 on issue 2259 by chip...@gmail.com: Replying to a comment on a review breaks the js popup on IE8 http://code.google.com/p/reviewboard/issues/detail?id=2259 I don't know off-hand. I'd need more information about what's being called and how it's breaking. Something to look at for 1.6.2. -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 2259 in reviewboard: Replying to a comment on a review breaks the js popup on IE8
Comment #1 on issue 2259 by atiannic...@gmail.com: Replying to a comment on a review breaks the js popup on IE8 http://code.google.com/p/reviewboard/issues/detail?id=2259 Is there any work around for this? Many of the people on our team use IE and it appears to be an issue for them. -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
