Re: Issue 2335 in reviewboard: post-review basedir
Comment #5 on issue 2335 by j...@purestorage.com: post-review basedir http://code.google.com/p/reviewboard/issues/detail?id=2335 This is absolutely a bug. There's no way for me to upload a diff that's generated in a child directory of the svn repo without manipulating the diff to include all directories between the repo root and the base directory. I know it's been stated that this is auto-detected, but if I want to upload a diff with no svn workspace (this is a very real use case with --diff-filename), I am stuck manipulating the diffs, which is not practical. I find it odd that the web interface has nothing working but the CLI no longer has a way of specifying the base dir. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 2335 in reviewboard: post-review basedir
Comment #6 on issue 2335 by j...@purestorage.com: post-review basedir http://code.google.com/p/reviewboard/issues/detail?id=2335 This is absolutely a bug. There's no way for me to upload a diff that's generated in a child directory of the svn repo without manipulating the diff to include all directories between the repo root and the base directory. I know it's been stated that this is auto-detected, but if I want to upload a diff with no svn workspace (this is a very real use case with --diff-filename), I am stuck manipulating the diffs, which is not practical. I find it odd that the web interface has this working but the CLI no longer has a way of specifying the base dir. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 2335 in reviewboard: post-review basedir
Updates: Status: Confirmed Labels: Component-RBTools Milestone-RBTools-Release1.0 Comment #7 on issue 2335 by chip...@gmail.com: post-review basedir http://code.google.com/p/reviewboard/issues/detail?id=2335 Seems there are some legitimate use cases we should address. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 2335 in reviewboard: post-review basedir
Comment #4 on issue 2335 by eya...@gmail.com: post-review basedir http://code.google.com/p/reviewboard/issues/detail?id=2335 I also want to use post-review --basedir, because the diff file is generated in a special logic, I do not want the post-review to auto check out the repository but to deal with an existing diff file... In such a situation, the basedir seems to be / all the time, that's absolutely a bug -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 2335 in reviewboard: post-review basedir
Comment #2 on issue 2335 by milan.ru...@gmail.com: post-review basedir http://code.google.com/p/reviewboard/issues/detail?id=2335 It is not ok because without --basedir the post-review does not work with SVN diff files.. ..or have you an idea how can I do it? Have you already try it in real SVN repository? Milan -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 2335 in reviewboard: post-review basedir
Comment #3 on issue 2335 by trowb...@gmail.com: post-review basedir http://code.google.com/p/reviewboard/issues/detail?id=2335 I suppose it might be necessary with --diff-filename, but if you're posting the change from an svn working directory, it will auto-detect it. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 2335 in reviewboard: post-review basedir
Updates: Status: NotABug Comment #1 on issue 2335 by trowb...@gmail.com: post-review basedir http://code.google.com/p/reviewboard/issues/detail?id=2335 There's no need for such an option, because post-review will automatically determine the basedir from your checkout. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
