Re: Issue 2445 in reviewboard: Unable to 'View Diff' when using with RhodeCode for mercurial repositories
Updates: Status: ThirdParty Comment #28 on issue 2445 by trowb...@gmail.com: Unable to 'View Diff' when using with RhodeCode for mercurial repositories http://code.google.com/p/reviewboard/issues/detail?id=2445 Until RhodeCode supports the necessary APIs, there's nothing we can do here. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Issue 2445 in reviewboard: Unable to 'View Diff' when using with RhodeCode for mercurial repositories
Comment #27 on issue 2445 by dotheb...@gmail.com: Unable to 'View Diff' when using with RhodeCode for mercurial repositories http://code.google.com/p/reviewboard/issues/detail?id=2445 Update: - 'Such revision does not exist for this repository' originated in me having a patch based on a first tested migration repo, which was recreated under the same name. - the rhodecode won't grant access to the /raw/ URLswith http-Auth-basic, but just web based cookie auth. - since I don't have access to the rhode code, plus the connection isn't fast enough anyways, I work with local clones which do polling. - while the URLs generated work well with rhode code work well in the browser (so if you use cookies everything is ok) it seems to break connection to traditional hg repositories. In general, is there a cheap way for reviewboard to keep its own clone of hg repositories in general? -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/groups/opt_out.
Re: Issue 2445 in reviewboard: Unable to 'View Diff' when using with RhodeCode for mercurial repositories
Comment #25 on issue 2445 by dotheb...@gmail.com: Unable to 'View Diff' when using with RhodeCode for mercurial repositories http://code.google.com/p/reviewboard/issues/detail?id=2445 So it seems as if the patch from #16 doesn't apply anymore since the 'hg-history' case was added. I've edited it so it applies cleanly to 1.7.20 so it generates queries this url: https://myrhodecode/hg/repo_URL/raw/5aa4fa3e1a60/path/to/rawfile.txt but when I browse rhode code, and try to get the latest version of this file in raw, it looks like that: https://myrhodecode/hg/repo_URL/raw/13a98ef355224d626c3bf3dbe0e5f1545052a230/path/to/rawfile.txt The request to the short (wrong) key results in the same 404 reply with the login dialog as everybody else experienced so far. Any hints where this hash is generated? and why its using a wrong one? Attachments: rb_hg_api_key_1.7.20.patch 3.6 KB -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/groups/opt_out.
Re: Issue 2445 in reviewboard: Unable to 'View Diff' when using with RhodeCode for mercurial repositories
Comment #26 on issue 2445 by dotheb...@gmail.com: Unable to 'View Diff' when using with RhodeCode for mercurial repositories http://code.google.com/p/reviewboard/issues/detail?id=2445 Oh, I have to correct myself. The reply actualy is: 'Such revision does not exist for this repository' -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/groups/opt_out.
Re: Issue 2445 in reviewboard: Unable to 'View Diff' when using with RhodeCode for mercurial repositories
Comment #24 on issue 2445 by kiran...@gmail.com: Unable to 'View Diff' when using with RhodeCode for mercurial repositories http://code.google.com/p/reviewboard/issues/detail?id=2445 Is there any solution available for this issue. I am facing a similar kind of issue. I am on Review Board 1.7.6. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/groups/opt_out.
Re: Issue 2445 in reviewboard: Unable to 'View Diff' when using with RhodeCode for mercurial repositories
Comment #22 on issue 2445 by rapid7...@gmail.com: Unable to 'View Diff' when using with RhodeCode for mercurial repositories http://code.google.com/p/reviewboard/issues/detail?id=2445 Not sure if it's in rhodecode upstream, but a good point. I'll check, though Marcin Kuzminski may have some questions. I'll direct him here. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 2445 in reviewboard: Unable to 'View Diff' when using with RhodeCode for mercurial repositories
Comment #20 on issue 2445 by rapid7...@gmail.com: Unable to 'View Diff' when using with RhodeCode for mercurial repositories http://code.google.com/p/reviewboard/issues/detail?id=2445 We've been using this patch since 1.6.12 and again on 1.6.15. I will check, but did it make it into 1.7.1? -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 2445 in reviewboard: Unable to 'View Diff' when using with RhodeCode for mercurial repositories
Comment #21 on issue 2445 by trowb...@gmail.com: Unable to 'View Diff' when using with RhodeCode for mercurial repositories http://code.google.com/p/reviewboard/issues/detail?id=2445 Is the rc_files_api_access.patch change in rhodecode upstream? I'm not comfortable including this in reviewboard until it works with all rhodecode repositories without making people patch their copy. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 2445 in reviewboard: Unable to 'View Diff' when using with RhodeCode for mercurial repositories
Updates: Status: New Comment #18 on issue 2445 by trowb...@gmail.com: Unable to 'View Diff' when using with RhodeCode for mercurial repositories http://code.google.com/p/reviewboard/issues/detail?id=2445 (No comment was entered for this change.) -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 2445 in reviewboard: Unable to 'View Diff' when using with RhodeCode for mercurial repositories
Comment #17 on issue 2445 by vairavan...@ciinow.com: Unable to 'View Diff' when using with RhodeCode for mercurial repositories http://code.google.com/p/reviewboard/issues/detail?id=2445 Awesome! Thank you so much Mike. I'm going to try your patch now! -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 2445 in reviewboard: Unable to 'View Diff' when using with RhodeCode for mercurial repositories
Comment #16 on issue 2445 by mike@gmail.com: Unable to 'View Diff' when using with RhodeCode for mercurial repositories http://code.google.com/p/reviewboard/issues/detail?id=2445 i have done some work-around to use the api-key when accessing rhodecode (1.3.6) hosted hg repo 1. apply attached patches, rc_ for rhodecode and rb_ for reviewboard 2. modify production.ini of installed rhodecode instance to turn off both container_auth and proxypass_auth now i could setup a rhodecode repo as custom hg repo with raw_file_url as repo url/raw/revision/filename?api_key=api-key and it's working ^_^ Attachments: rb_hg_api_key.patch 3.5 KB rc_files_api_access.patch 706 bytes -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 2445 in reviewboard: Unable to 'View Diff' when using with RhodeCode for mercurial repositories
Comment #12 on issue 2445 by mike@gmail.com: Unable to 'View Diff' when using with RhodeCode for mercurial repositories http://code.google.com/p/reviewboard/issues/detail?id=2445 i think the problem is caused by some sort of errors of authentication, thus rhodecode redirect the request to the login page which is exactly the content of the temporary file. however, in recent rhodecode version, an api-key is added, so the solution might be getting raw files with api-key. i am not familiar with python, not to mention the reviewboard itself, but from the form of repository creation, i think maybe we could add api-key option for custom type of repository, or add Rhodecode as a hosting service with field of username and password replaced with api-key. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 2445 in reviewboard: Unable to 'View Diff' when using with RhodeCode for mercurial repositories
Comment #13 on issue 2445 by mike@gmail.com: Unable to 'View Diff' when using with RhodeCode for mercurial repositories http://code.google.com/p/reviewboard/issues/detail?id=2445 forgot to mention: just add api-key=api-key to GET parameter to access without login and by default, rhodecode turns off accessing files via api-key, so rhodecode itself has to be modified too. more information could be found at http://bit.ly/Molott and complete api document is at http://bit.ly/MolDom btw, according to the log of apache, the initial raw file url requested from rb is indeed wrong, but the second try is correct: rhodecode url/raw/revision id/path to file -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 2445 in reviewboard: Unable to 'View Diff' when using with RhodeCode for mercurial repositories
Comment #14 on issue 2445 by vairavan...@ciinow.com: Unable to 'View Diff' when using with RhodeCode for mercurial repositories http://code.google.com/p/reviewboard/issues/detail?id=2445 Hi Mike, Thank you so much for the pointer. I will try it out today and will update this issue. This is of great help! Thanks again, Vairav. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 2445 in reviewboard: Unable to 'View Diff' when using with RhodeCode for mercurial repositories
Comment #15 on issue 2445 by mike@gmail.com: Unable to 'View Diff' when using with RhodeCode for mercurial repositories http://code.google.com/p/reviewboard/issues/detail?id=2445 i am glad to help, too ^_^ as i have mentioned that i am not familiar with reviewboard and that i have no clue of modifying how rb is accessing rhodecode. my intention is to at least provide some observation to draw some attention here and hoping that someone could come out with a solution. so i am looking forward to your progress, too :) -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 2445 in reviewboard: Unable to 'View Diff' when using with RhodeCode for mercurial repositories
Comment #11 on issue 2445 by mikael.a...@gmail.com: Unable to 'View Diff' when using with RhodeCode for mercurial repositories http://code.google.com/p/reviewboard/issues/detail?id=2445 I think I'm having the same issue. When trying to patch file A I get the same message saying that patch failed. When looking at the temp files I see that the file ReviewBoard is trying to patch is an old version of A. Exception for the changeset up for review, both local and master repositories share the same state. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 2445 in reviewboard: Unable to 'View Diff' when using with RhodeCode for mercurial repositories
Comment #10 on issue 2445 by vayira...@gmail.com: Unable to 'View Diff' when using with RhodeCode for mercurial repositories http://code.google.com/p/reviewboard/issues/detail?id=2445 Hi Trowb, Sorry for the very late response. I was trying to figure out on how to get the raw file url, but unable to do so. The only thing that I was able to narrow down was that, Rhodecode, when authenticated gives the proper url. If you can advice me on how to go about getting the Raw file url, it would be great! Thanks, Vairav -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 2445 in reviewboard: Unable to 'View Diff' when using with RhodeCode for mercurial repositories
Comment #9 on issue 2445 by trowb...@gmail.com: Unable to 'View Diff' when using with RhodeCode for mercurial repositories http://code.google.com/p/reviewboard/issues/detail?id=2445 Your raw file url is wrong. You need to figure out how to get the contents of files at specific revisions from RhodeCode. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 2445 in reviewboard: Unable to 'View Diff' when using with RhodeCode for mercurial repositories
Comment #8 on issue 2445 by vayira...@gmail.com: Unable to 'View Diff' when using with RhodeCode for mercurial repositories http://code.google.com/p/reviewboard/issues/detail?id=2445 Hi, sorry to bump on the issue, but just wanted to check to see if there are any possible solutions. Thanks again, Vairav -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 2445 in reviewboard: Unable to 'View Diff' when using with RhodeCode for mercurial repositories
Comment #6 on issue 2445 by vayira...@gmail.com: Unable to 'View Diff' when using with RhodeCode for mercurial repositories http://code.google.com/p/reviewboard/issues/detail?id=2445 Hi Trowb, I found something very interesting today. When I opened up another past review, and clicked on 'View Diff', it showed me the same error (and it was reviewboard.5q4R0F with the file tmpShBACU, etc.) So when I opened up the file 'tmpShBACU', it was very identical to some other review that which I had submitted and had no relation to it. Later when I logged into RhodeCode manually, I saw the source of the first landing page, i.e. RhodeCode's index page, and surprisingly, the contents of the file are nothing but the index page of RhodeCode. Could you please let me know on why this is happening? Or what has to be done? I can confirm that all the reviews that produced the reject files, has the same index page of RhodeCode. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 2445 in reviewboard: Unable to 'View Diff' when using with RhodeCode for mercurial repositories
Comment #7 on issue 2445 by vayira...@gmail.com: Unable to 'View Diff' when using with RhodeCode for mercurial repositories http://code.google.com/p/reviewboard/issues/detail?id=2445 The tmpShBACU file for your reference is attached with this post. Attachments: tmpShBACU 6.4 KB -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 2445 in reviewboard: Unable to 'View Diff' when using with RhodeCode for mercurial repositories
Comment #4 on issue 2445 by vayira...@gmail.com: Unable to 'View Diff' when using with RhodeCode for mercurial repositories http://code.google.com/p/reviewboard/issues/detail?id=2445 Hi, just to update, I was looking through the settings in reviewboard to see if the paths are correct, but when I open the older reviews that I had added during the old setup, i.e. Reviewboard + hgweb.cgi, when I downloaded the diffs, they are having the proper paths on the top of the file. Similarly, when I did the same for the newer reviews that I had added with the new setup, i.e. Reviewboard + Rhodecode, similarly, the paths are all correct and they are looking normal. Is it something to do with the authentication portion of the Reviewboard with Rhodecode? I did enter the username and password similar to the way its done for Bitbucket repositories in the 'Repo' section of the Admin Panel. Please advice. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 2445 in reviewboard: Unable to 'View Diff' when using with RhodeCode for mercurial repositories
Comment #5 on issue 2445 by trowb...@gmail.com: Unable to 'View Diff' when using with RhodeCode for mercurial repositories http://code.google.com/p/reviewboard/issues/detail?id=2445 If the contents of the file are what you expect, it's not an authentication problem. Are you sure the line endings match between the file and the patch? -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 2445 in reviewboard: Unable to 'View Diff' when using with RhodeCode for mercurial repositories
Updates: Status: NeedInfo Comment #1 on issue 2445 by trowb...@gmail.com: Unable to 'View Diff' when using with RhodeCode for mercurial repositories http://code.google.com/p/reviewboard/issues/detail?id=2445 It looks like the contents of the raw file that RhodeCode is giving you is bogus. Can you look at /tmp/reviewboard.uV5elT/tmplXUpmn and see what's in it? -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 2445 in reviewboard: Unable to 'View Diff' when using with RhodeCode for mercurial repositories
Comment #2 on issue 2445 by vayira...@gmail.com: Unable to 'View Diff' when using with RhodeCode for mercurial repositories http://code.google.com/p/reviewboard/issues/detail?id=2445 Hi trowb, I saw the contents of the file tmplXUpmn and tempXUpmn-new, and found that both the files are identical. Also, the file tmplXUpmn has my index.xhtml content. Then I compared two other files which are present in the same directory, which are: 1. index.xhtml.diff 2. tmplXUpmn-new.rej When comparing both these files I found that index.xhtml.diff had this extra online as the first line in the file and the paths in the 2nd and 3rd lines were different too: [code] diff -r 4020b8bf5e12 -r cd26cce649a2 develop/src/modules/controller/src/main/webapp/index.xhtml --- a/develop/src/modules/controller/src/main/webapp/index.xhtml Fri Dec 16 16:07:19 2011 -0800 +++ b/develop/src/modules/controller/src/main/webapp/index.xhtml Tue Dec 20 15:03:31 2011 -0800 [/code] Whereas in tmplXUpmn-new.rej I'm having the following lines: [code] --- index.xhtml Fri Dec 16 16:07:19 2011 -0800 +++ index.xhtml Tue Dec 20 15:03:31 2011 -0800 [/code] I'm not sure on why the paths are different in both these files. Please let me know if you need any more information. I'm not sure on what to look out for in those file and any guidances would be really helpful. Regards, Vairav -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 2445 in reviewboard: Unable to 'View Diff' when using with RhodeCode for mercurial repositories
Comment #3 on issue 2445 by vayira...@gmail.com: Unable to 'View Diff' when using with RhodeCode for mercurial repositories http://code.google.com/p/reviewboard/issues/detail?id=2445 Also to add, I'm using mercurial-reviewboard plugin with my mercurial to do the 'hg postreview -o revision no.' to post it to the reviewboard. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
