Re: Issue 2561 in reviewboard: Subversion diff failed to parse
Comment #7 on issue 2561 by charlie@nielsen.com: Subversion diff failed to parse http://code.google.com/p/reviewboard/issues/detail?id=2561 Is this the recommended way to overcome this issue? I guess I'm wondering if this is a bug in RB where it does not handle the diff of a property change correctly. -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 2561 in reviewboard: Subversion diff failed to parse
Comment #6 on issue 2561 by chip...@gmail.com: Subversion diff failed to parse http://code.google.com/p/reviewboard/issues/detail?id=2561 Yeah, that's what I was alluding to in the e-mail thread. Commit the property change (it's something you must commit instead of just having locally), and then other diffs should work fine. -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 2561 in reviewboard: Subversion diff failed to parse
Updates: Status: Duplicate Mergedinto: 2359 Comment #5 on issue 2561 by trowb...@gmail.com: Subversion diff failed to parse http://code.google.com/p/reviewboard/issues/detail?id=2561 (No comment was entered for this change.) -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 2561 in reviewboard: Subversion diff failed to parse
Comment #4 on issue 2561 by csal...@hotmail.com: Subversion diff failed to parse http://code.google.com/p/reviewboard/issues/detail?id=2561 OK, after more investigation I found the issue: The diff on my windows system includes the following: Index: === --- (revision 12) +++ (working copy) Property changes on: . ___ Modified: reviewboard:url ## -1 +1 ## -http://www.charlie.com +http://www.rbdemo.com because I committed the property change at one time to the repository and then tried to change the svn property reviewboard:url from www.charlie.com to www.rbdemo.com. Christian, Is this a bug that diff cannot handle changes to SVN properties? Should post-review ignore these types of diffs. Thanks, Charlie -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 2561 in reviewboard: Subversion diff failed to parse
Comment #3 on issue 2561 by csal...@hotmail.com: Subversion diff failed to parse http://code.google.com/p/reviewboard/issues/detail?id=2561 I created another Windows environment and tried to run a post-review from that system. The results were the same. That would indicate an issue on the server hosting ReviewBoard. The question now is what is that issue? -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 2561 in reviewboard: Subversion diff failed to parse
Comment #2 on issue 2561 by csal...@hotmail.com: Subversion diff failed to parse http://code.google.com/p/reviewboard/issues/detail?id=2561 Here is the version of diff post-review is using: Z:\myrepo>diff --version diff (GNU diffutils) 2.8.7 Written by Paul Eggert, Mike Haertel, David Hayes, Richard Stallman, and Len Tower. Copyright (C) 2004 Free Software Foundation, Inc. This is free software; see the source for copying conditions. There is NO warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. Here is the entire output of the post-review --debug --output-diff: Z:\myrepo>post-review --debug --output-diff >>> RBTools 0.4.1 >>> Home = C:\Users\salech01\AppData\Roaming >>> HTTP GETting api/ >>> HTTP GETting http://www.rbdemo.com/api/info/ >>> Using the new web API Index: === --- (revision 12) +++ (working copy) Property changes on: . ___ Modified: reviewboard:url ## -1 +1 ## -http://www.charlie.com +http://www.rbdemo.com \ No newline at end of property Index: /trunk/terrytest.txt === --- /trunk/terrytest.txt(revision 12) +++ /trunk/terrytest.txt(working copy) @@ -1,3 +1,5 @@ test 2 test 3 -test 4 \ No newline at end of file +test 4 +Charlie 5 +Charlie 6 Z:\myrepo> Here is an svn diff of the repository: Z:\myrepo>svn diff Index: . === --- . (revision 12) +++ . (working copy) Property changes on: . ___ Modified: reviewboard:url ## -1 +1 ## -http://www.charlie.com +http://www.rbdemo.com \ No newline at end of property Index: trunk/terrytest.txt === --- trunk/terrytest.txt (revision 12) +++ trunk/terrytest.txt (working copy) @@ -1,3 +1,5 @@ test 2 test 3 -test 4 \ No newline at end of file +test 4 +Charlie 5 +Charlie 6 Z:\myrepo> Thanks! -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 2561 in reviewboard: Subversion diff failed to parse
Updates: Summary: Subversion diff failed to parse Status: NeedInfo Labels: Component-DiffParser Comment #1 on issue 2561 by chip...@gmail.com: Subversion diff failed to parse http://code.google.com/p/reviewboard/issues/detail?id=2561 So something about the diff itself is breaking the parser. We apparently don't handle the format. What's generating the diff? It'll be important to see the headers of the diff. Everything but file content is necessary, and spaces/tabs/etc. must be preserved. -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
