Re: Issue 3013 in reviewboard: Deleting a file attachment does not delete comments about it from issue summary table
Comment #4 on issue 3013 by ilacknor...@gmail.com: Deleting a file attachment does not delete comments about it from issue summary table http://code.google.com/p/reviewboard/issues/detail?id=3013 The submitter is still allowed to mark the comment as "Fixed" or "Dropped". That makes sense. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/groups/opt_out.
Re: Issue 3013 in reviewboard: Deleting a file attachment does not delete comments about it from issue summary table
Comment #3 on issue 3013 by chip...@gmail.com: Deleting a file attachment does not delete comments about it from issue summary table http://code.google.com/p/reviewboard/issues/detail?id=3013 I can see an argument for that, but there's another argument that I believe requires that we keep behavior as-is. Say I upload a screenshot, and people make comments on it. I may, as part of a subsequent update, replace that screenshot with a newer version, without addressing their concerns. For example, maybe I tweaked the look of something, but I didn't fix a typo they found. By altering this behavior to erase those issues from the removed screenshot, I lose very valuable feedback that may still be very relevant. I don't want to do that. Just because a file attachment (or diff) was replaced, doesn't mean the previous feedback has been addressed. What *should* be done is that the owner of the review request should close the issues once they are fixed. Reviews should *never* disappear. It's up to the owner to respond to any open issues, and having the system auto-close them is asking for trouble. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/groups/opt_out.
Re: Issue 3013 in reviewboard: Deleting a file attachment does not delete comments about it from issue summary table
Comment #2 on issue 3013 by ilacknor...@gmail.com: Deleting a file attachment does not delete comments about it from issue summary table http://code.google.com/p/reviewboard/issues/detail?id=3013 Like I mentioned earlier, I think it is valuable to keep all discussions in the review updates below (I'm not suggesting that), but I don't think the comment should be listed as an "Open" Issue on the Issue Summary Table when in fact the file attachment no longer exists. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/groups/opt_out.
Re: Issue 3013 in reviewboard: Deleting a file attachment does not delete comments about it from issue summary table
Updates: Status: NotABug Comment #1 on issue 3013 by trowb...@gmail.com: Deleting a file attachment does not delete comments about it from issue summary table http://code.google.com/p/reviewboard/issues/detail?id=3013 This is expected behavior. People often remove file attachments in favor of a new version of the same file, but we don't want to erase all discussion that happened before. Just close the issue if it no longer applies. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/groups/opt_out.
