Re: Issue 3020 in reviewboard: RBTools / post-review.py ignores https prefix

2013-08-07 Thread reviewboard

Updates:
Status: SetupIssue

Comment #5 on issue 3020 by trowb...@gmail.com: RBTools / post-review.py  
ignores https prefix

http://code.google.com/p/reviewboard/issues/detail?id=3020

(No comment was entered for this change.)

--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/groups/opt_out.


Re: Issue 3020 in reviewboard: RBTools / post-review.py ignores https prefix

2013-06-25 Thread reviewboard


Comment #1 on issue 3020 by chip...@gmail.com: RBTools / post-review.py  
ignores https prefix

http://code.google.com/p/reviewboard/issues/detail?id=3020

Looks like the server isn't being told it needs to give HTTPS URLs back.  
This is a server-side config issue, rather than client-side. It's often due  
to having something sitting in front of Apache that's handling the SSL.


Try adding this to the reviewboard.wsgi file:

os.environ['HTTPS'] = 'on'

--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/groups/opt_out.




Re: Issue 3020 in reviewboard: RBTools / post-review.py ignores https prefix

2013-06-25 Thread reviewboard


Comment #2 on issue 3020 by f...@leibert.de: RBTools / post-review.py  
ignores https prefix

http://code.google.com/p/reviewboard/issues/detail?id=3020

This is not true. This is clearly a client side bug. I am not evening  
running plain HTTP only HTTPS!


--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/groups/opt_out.




Re: Issue 3020 in reviewboard: RBTools / post-review.py ignores https prefix

2013-06-25 Thread reviewboard


Comment #3 on issue 3020 by f...@leibert.de: RBTools / post-review.py  
ignores https prefix

http://code.google.com/p/reviewboard/issues/detail?id=3020

Why would the client assume there is a HTTP server running as opposed to a  
HTTPS server in first place?


--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/groups/opt_out.




Re: Issue 3020 in reviewboard: RBTools / post-review.py ignores https prefix

2013-06-25 Thread reviewboard


Comment #4 on issue 3020 by chip...@gmail.com: RBTools / post-review.py  
ignores https prefix

http://code.google.com/p/reviewboard/issues/detail?id=3020

It is true, and it is not a client-side bug. We are very well aware of this  
behavior.


The client did not generate the URL http:///api/review-requests/;. The  
server built that link and told the client to use it for the request for  
review requests. Beyond the first root URL, the client has no knowledge of  
where anything lives and does not build paths. You can verify this by going  
to https://rb.mesosphere.com/api/ and see the URLs it returns.


The server will build a link with https:// if it knows it's supposed to.  
Your server doesn't. You need to set the HTTPS environment variable to on  
to force it (as per Django's URL building logic).


--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/groups/opt_out.