Re: Issue 3207 in reviewboard: Creating a new review request for commited change fails for first commit
Updates: Status: PendingReview Comment #4 on issue 3207 by trowb...@gmail.com: Creating a new review request for commited change fails for first commit http://code.google.com/p/reviewboard/issues/detail?id=3207 (No comment was entered for this change.) -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/groups/opt_out.
Re: Issue 3207 in reviewboard: Creating a new review request for commited change fails for first commit
Updates: Status: NeedInfo Comment #1 on issue 3207 by trowb...@gmail.com: Creating a new review request for commited change fails for first commit http://code.google.com/p/reviewboard/issues/detail?id=3207 Can you include the error that's raised? -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/groups/opt_out.
Re: Issue 3207 in reviewboard: Creating a new review request for commited change fails for first commit
Comment #2 on issue 3207 by anselina...@gmail.com: Creating a new review request for commited change fails for first commit http://code.google.com/p/reviewboard/issues/detail?id=3207 Of course - here it is: [24/Jan/2014 02:37:14] GET /api/repositories/1/branches/?api_format=json HTTP/1.1 200 119 [24/Jan/2014 02:37:14] GET /api/repositories/1/commits/?start=6ffd5ae34f2b790afec4b082f2b64255bdfa4fb2api_format=json HTTP/1.1 200 182 2014-01-24 02:37:26,568 - ERROR - None - anselina - /api/review-requests/ - Got unexpected SCMError when creating repository: Not Found Traceback (most recent call last): File /home/anselina/src/reviewboard/reviewboard/webapi/resources/review_request.py, line 519, in create user, repository, commit_id, local_site) File /home/anselina/src/reviewboard/reviewboard/reviews/managers.py, line 132, in create review_request.update_from_commit_id(commit_id) File /home/anselina/src/reviewboard/reviewboard/reviews/models/base_review_request_details.py, line 182, in update_from_commit_id self.update_from_committed_change(commit_id) File /home/anselina/src/reviewboard/reviewboard/reviews/models/base_review_request_details.py, line 230, in update_from_committed_change commit = self.repository.get_change(commit_id) File /home/anselina/src/reviewboard/reviewboard/scmtools/models.py, line 296, in get_change return hosting_service.get_change(self, revision) File /home/anselina/src/reviewboard/reviewboard/hostingsvcs/github.py, line 409, in get_change raise SCMError(six.text_type(e)) SCMError: Not Found [24/Jan/2014 02:37:26] POST /api/review-requests/ HTTP/1.1 500 118 -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/groups/opt_out.
Re: Issue 3207 in reviewboard: Creating a new review request for commited change fails for first commit
Comment #3 on issue 3207 by anselina...@gmail.com: Creating a new review request for commited change fails for first commit http://code.google.com/p/reviewboard/issues/detail?id=3207 I'll also fix this! The problem is that the first commit has no parents, so it fails when it tries to fetch the compare two commits API (in reviewboard/hostingsvcs/github.py's get_change) since parent_revision is empty. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/groups/opt_out.
