Re: Issue 3329 in reviewboard: Show proper error message when attempting to publish review request with duplicate commit ID
Comment #7 on issue 3329 by trowb...@gmail.com: Show proper error message when attempting to publish review request with duplicate commit ID http://code.google.com/p/reviewboard/issues/detail?id=3329 I think that yours is a separate bug. Would you mind filing it, and including the stack trace? -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Issue 3329 in reviewboard: Show proper error message when attempting to publish review request with duplicate commit ID
Comment #6 on issue 3329 by thom.ger...@gmail.com: Show proper error message when attempting to publish review request with duplicate commit ID http://code.google.com/p/reviewboard/issues/detail?id=3329 Seeing this in deployed Reviewboard 2.0.1 with a MySQL db. user doing PUT /api/review-requests//draft/ and getting a 500 error. The exception is IntegrityError(1062, "Duplicate entry '.' for key 'reviews_reviewrequest_b8c24015'") ... would a stack trace be helpful? The last bit of reviewboard code before all the django mysql stuff is: File "reviewboard/webapi/resources/review_request_draft.py", line 394, in update review_request.publish(user=request.user) -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Issue 3329 in reviewboard: Show proper error message when attempting to publish review request with duplicate commit ID
Comment #5 on issue 3329 by chip...@gmail.com: Show proper error message when attempting to publish review request with duplicate commit ID http://code.google.com/p/reviewboard/issues/detail?id=3329 (Actually, I imagine it just doesn't crash because it's SQLite3, which I think is less strict?) -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Issue 3329 in reviewboard: Show proper error message when attempting to publish review request with duplicate commit ID
Updates: Status: Confirmed Labels: Component-Reviews Comment #4 on issue 3329 by chip...@gmail.com: Show proper error message when attempting to publish review request with duplicate commit ID http://code.google.com/p/reviewboard/issues/detail?id=3329 This is certainly harder to hit now, but not fully fixed. The following repro case results in two review requests with the same commit ID: 1. Run `rbt post` 2. Update the branch, run `rbt post` again, creating a new review request. 3. Update the original review request with `rbt post -r `. 4. Publish both review requests. While it doesn't seem to break anymore (fortunately), it does result in two review requests with the same commit ID. We need to check more thoroughly that publishing a draft wouldn't result in a duplicate commit ID, before any actual publishing takes place. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Issue 3329 in reviewboard: Show proper error message when attempting to publish review request with duplicate commit ID
Updates: Status: Fixed Comment #3 on issue 3329 by trowb...@gmail.com: Show proper error message when attempting to publish review request with duplicate commit ID http://code.google.com/p/reviewboard/issues/detail?id=3329 Fixed in release-2.0.x (eec377b). Thanks! -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Issue 3329 in reviewboard: Show proper error message when attempting to publish review request with duplicate commit ID
Updates: Status: PendingReview Comment #2 on issue 3329 by trowb...@gmail.com: Show proper error message when attempting to publish review request with duplicate commit ID http://code.google.com/p/reviewboard/issues/detail?id=3329 (No comment was entered for this change.) -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Issue 3329 in reviewboard: Show proper error message when attempting to publish review request with duplicate commit ID
Comment #1 on issue 3329 by matthewc...@gmail.com: Show proper error message when attempting to publish review request with duplicate commit ID http://code.google.com/p/reviewboard/issues/detail?id=3329 I'll work on this. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
