Re: Issue 3411 in reviewboard: favicon not shown in diff view

Updates: Status: Fixed Comment #11 on issue 3411 by trowb...@gmail.com: favicon not shown in diff view https://code.google.com/p/reviewboard/issues/detail?id=3411 Neat. -- You received this message because this project is configured to send all issue notifications to this address.

Re: Issue 3411 in reviewboard: favicon not shown in diff view

Comment #10 on issue 3411 by griffin@gmail.com: favicon not shown in diff view https://code.google.com/p/reviewboard/issues/detail?id=3411 As far as I can tell this was fixed in 42aee3b. I now correctly see the favicon on diff viewer pages. Confirmed in Firefox 36.0.1 on Windows and

Re: Issue 3411 in reviewboard: favicon not shown in diff view

Comment #9 on issue 3411 by griffin@gmail.com: favicon not shown in diff view https://code.google.com/p/reviewboard/issues/detail?id=3411 I ran across this issue and found it a little annoying so I thought I would poke at it a bit. From Googling it appears it is indeed a Firefox bug:

Re: Issue 3411 in reviewboard: favicon not shown in diff view

Updates: Labels: -EasyFix Comment #8 on issue 3411 by mike.d.c...@gmail.com: favicon not shown in diff view https://code.google.com/p/reviewboard/issues/detail?id=3411 Removing EasyFix for now - I don't think crushing the size of the favicon is going to fix this. -- You received t

Re: Issue 3411 in reviewboard: favicon not shown in diff view

Comment #7 on issue 3411 by mike.d.c...@gmail.com: favicon not shown in diff view https://code.google.com/p/reviewboard/issues/detail?id=3411 Bumping browser.chrome.image_icon.max_size and following the STR in the main comment does not fix the issue for me. I also have a feeling this is a

Re: Issue 3411 in reviewboard: favicon not shown in diff view

Updates: Labels: EasyFix Component-WebUI Comment #6 on issue 3411 by trowb...@gmail.com: favicon not shown in diff view https://code.google.com/p/reviewboard/issues/detail?id=3411 (No comment was entered for this change.) -- You received this message because this project is configure

Re: Issue 3411 in reviewboard: favicon not shown in diff view

Updates: Status: New Comment #5 on issue 3411 by trowb...@gmail.com: favicon not shown in diff view http://code.google.com/p/reviewboard/issues/detail?id=3411 (No comment was entered for this change.) -- You received this message because this project is configured to send all issue

Re: Issue 3411 in reviewboard: favicon not shown in diff view

Comment #4 on issue 3411 by trowb...@gmail.com: favicon not shown in diff view http://code.google.com/p/reviewboard/issues/detail?id=3411 Huh, interesting. I wonder if there's a way to crush the .ico files to be smaller. If not, we should probably just cut the cord to the past and switch

Re: Issue 3411 in reviewboard: favicon not shown in diff view

Comment #3 on issue 3411 by bruce.c...@gmail.com: favicon not shown in diff view http://code.google.com/p/reviewboard/issues/detail?id=3411 Apparently Firefox by default limits favicon sizes to 1KB - see the browser.chrome.image_icon.max_size setting (and https://bugzilla.mozilla.org/show

Re: Issue 3411 in reviewboard: favicon not shown in diff view

Updates: Status: ThirdParty Comment #2 on issue 3411 by trowb...@gmail.com: favicon not shown in diff view http://code.google.com/p/reviewboard/issues/detail?id=3411 This definitely seems to be a bug in Firefox. Other browsers handle this correctly. -- You received this message be

Re: Issue 3411 in reviewboard: favicon not shown in diff view

Updates: Status: Confirmed Comment #1 on issue 3411 by chip...@gmail.com: favicon not shown in diff view http://code.google.com/p/reviewboard/issues/detail?id=3411 Very weird. We have the same HTML linking to the favicon on both pages. I think this happens only when our Backbone rout