Re: Issue 3426 in reviewboard: "Didn't apply patch cleanly"

Comment #14 on issue 3426 by chip...@gmail.com: "Didn't apply patch cleanly" http://code.google.com/p/reviewboard/issues/detail?id=3426 Can you give that example with a sample tree of commits? (Just a diagram showing commits, what's upstream, and what's still local to your tree.) We strongly

Re: Issue 3426 in reviewboard: "Didn't apply patch cleanly"

Comment #13 on issue 3426 by nick.ind...@gmail.com: "Didn't apply patch cleanly" http://code.google.com/p/reviewboard/issues/detail?id=3426 git diff --full-index [hash of last commit that I uploaded] [file that was changed] > changes.diff -- You received this message because this project

Re: Issue 3426 in reviewboard: "Didn't apply patch cleanly"

Comment #12 on issue 3426 by trowb...@gmail.com: "Didn't apply patch cleanly" http://code.google.com/p/reviewboard/issues/detail?id=3426 It shouldn't matter if any new commits have been pushed--that's why we take advantage of the blob IDs in your diff. How are you creating your diff files

Re: Issue 3426 in reviewboard: "Didn't apply patch cleanly"

Comment #11 on issue 3426 by nick.ind...@gmail.com: "Didn't apply patch cleanly" http://code.google.com/p/reviewboard/issues/detail?id=3426 Finally fixed the problem. It seems the repo in the server was a few commits ahead. I had to pull the repo fresh, use my first patch to get the file

Re: Issue 3426 in reviewboard: "Didn't apply patch cleanly"

Comment #10 on issue 3426 by nick.ind...@gmail.com: "Didn't apply patch cleanly" http://code.google.com/p/reviewboard/issues/detail?id=3426 Sorry for bothering you with this, thanks for your help so far. I've got it traced back to get_original_file in diffutils.py. repository.get_file(...)

Re: Issue 3426 in reviewboard: "Didn't apply patch cleanly"

Comment #9 on issue 3426 by nick.ind...@gmail.com: "Didn't apply patch cleanly" http://code.google.com/p/reviewboard/issues/detail?id=3426 Shoot, admin's telling me that that was just a typo when he sent me the url... It actually is just revision. -- You received this message because this

Re: Issue 3426 in reviewboard: "Didn't apply patch cleanly"

Comment #8 on issue 3426 by trowb...@gmail.com: "Didn't apply patch cleanly" http://code.google.com/p/reviewboard/issues/detail?id=3426 I think your issue is "" (should be "") -- You received this message because this project is configured to send all issue notifications to this address. You

Re: Issue 3426 in reviewboard: "Didn't apply patch cleanly"

Comment #7 on issue 3426 by nick.ind...@gmail.com: "Didn't apply patch cleanly" http://code.google.com/p/reviewboard/issues/detail?id=3426 Ah, here is the raw file URL: http://server/gitweb/?p=myrepo.git;a=blob_plain;f=;h= -- You received this message because this project is configured to se

Re: Issue 3426 in reviewboard: "Didn't apply patch cleanly"

Comment #6 on issue 3426 by nick.ind...@gmail.com: "Didn't apply patch cleanly" http://code.google.com/p/reviewboard/issues/detail?id=3426 We're using gitweb and hosting the repos at the default location on our server (/srv/git/repositories) -- You received this message because this proje

Re: Issue 3426 in reviewboard: "Didn't apply patch cleanly"

Comment #5 on issue 3426 by trowb...@gmail.com: "Didn't apply patch cleanly" http://code.google.com/p/reviewboard/issues/detail?id=3426 How is your repository configured? What is the raw file URL? -- You received this message because this project is configured to send all issue notifications

Re: Issue 3426 in reviewboard: "Didn't apply patch cleanly"

Comment #4 on issue 3426 by nick.ind...@gmail.com: "Didn't apply patch cleanly" http://code.google.com/p/reviewboard/issues/detail?id=3426 Git -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification

Re: Issue 3426 in reviewboard: "Didn't apply patch cleanly"

Comment #3 on issue 3426 by trowb...@gmail.com: "Didn't apply patch cleanly" http://code.google.com/p/reviewboard/issues/detail?id=3426 It should be the tmp1 file. If it's empty, something went wrong fetching the file from the repository. What SCM are you using? -- You received this message

Re: Issue 3426 in reviewboard: "Didn't apply patch cleanly"

Comment #2 on issue 3426 by nick.ind...@gmail.com: "Didn't apply patch cleanly" http://code.google.com/p/reviewboard/issues/detail?id=3426 Is that also stored within the temp folder? In there I see: tmp1 and tmp1-new files, both have nothing in them myfile.py.diff, which is the diff I uploade

Re: Issue 3426 in reviewboard: "Didn't apply patch cleanly"

Updates: Status: NeedInfo Comment #1 on issue 3426 by trowb...@gmail.com: "Didn't apply patch cleanly" http://code.google.com/p/reviewboard/issues/detail?id=3426 Can you check that the file it's trying to patch looks correct? -- You received this message because this project is configur