Re: Issue 3558 in reviewboard: RB doesn't handle paths containing spaces correctly
Updates: Status: Fixed Comment #5 on issue 3558 by trowb...@gmail.com: RB doesn't handle paths containing spaces correctly https://code.google.com/p/reviewboard/issues/detail?id=3558 Fixed in release-2.0.x (de3bbf7). This will ship in 2.0.10 -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Issue 3558 in reviewboard: RB doesn't handle paths containing spaces correctly
Comment #4 on issue 3558 by gheaeckk...@gmail.com: RB doesn't handle paths containing spaces correctly https://code.google.com/p/reviewboard/issues/detail?id=3558 Hi everyone, I've been looking into this issue quickly, The problem comes from this code : diff_line = self.lines[linenum].split() try: # Need to remove the a/ and b/ prefix file_info.origFile = GIT_DIFF_PREFIX.sub(b, diff_line[-2]) file_info.newFile = GIT_DIFF_PREFIX.sub(b, diff_line[-1]) Parsing this line : diff --git a/File name with spaces.pdf b/File name with spaces.pdf This will result in origFile = with and newFile = spaces.pdf I was thinking about doing something like using regex /a(.*)/b /b(.*)$ But if you path looks like 'somefolder b/your file', this will fail again. Other solution is to update file_info.origFile file_info.newFile with regex as you read the file Binary files /dev/null and b/File name with spaces.pdf differ = 'Binary files /dev/null and b/(.*) differ' But this mean adding code (with regex) for every condition in if self._is_new_file(linenum): elif self._is_deleted_file(linenum): elif self._is_mode_change(linenum): elif self._is_moved_file(linenum): elif self._is_copied_file(linenum): If anyone thinks of a better way to deal with that, please let me know :) -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Issue 3558 in reviewboard: RB doesn't handle paths containing spaces correctly
Updates: Status: New Labels: EasyFix Component-SCMTools Comment #3 on issue 3558 by trowb...@gmail.com: RB doesn't handle paths containing spaces correctly https://code.google.com/p/reviewboard/issues/detail?id=3558 (No comment was entered for this change.) -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Issue 3558 in reviewboard: RB doesn't handle paths containing spaces correctly
Updates: Status: NeedInfo Comment #1 on issue 3558 by chip...@gmail.com: RB doesn't handle paths containing spaces correctly https://code.google.com/p/reviewboard/issues/detail?id=3558 Can you attach a screenshot for this? -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Issue 3558 in reviewboard: RB doesn't handle paths containing spaces correctly
Comment #2 on issue 3558 by matthias...@gmail.com: RB doesn't handle paths containing spaces correctly https://code.google.com/p/reviewboard/issues/detail?id=3558 Determination of source revision doesn't always fail, as you can see in rb02.png. Weird. Attachments: rb01.png 142 KB rb02.png 118 KB -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
